Improve reporting for missing kubeconfig and error connecting to the cluster #725
Conversation
There was a problem hiding this comment.
@navidshaikh: 1 warning.
In response to this:
Fixes #315
Description
- Improve error reporting if
- kubeconfig file is missing or
- there is no route to host
- i/o timeout
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
size/L
Fixes knative#315 - Improve error reporting if - kubeconfig file is missing or - there is no route to host - i/o timeout
|
The following is the coverage report on the affected files.
|
| return NewKNError(msg) | ||
| } | ||
|
|
||
| func newNoRouteToHost(errString string) error { |
There was a problem hiding this comment.
I would add an "Error" suffix to the method name (same below)
| return false | ||
| } | ||
|
|
||
| func isNoRouteToHostError(err error) bool { | ||
| return strings.Contains(err.Error(), "no route to host") || strings.Contains(err.Error(), "i/o timeout") |
There was a problem hiding this comment.
basing actions on error descriptions is quite fragile. I wonder whether there is a better, typed approach ?
We can also think about it later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is great :) Thank you so much! |
let error message be meaningful instead of showing binary string
Fixes #315
Description
/lint