Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e for user flag #692

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Conversation

itsmurugappan
Copy link
Contributor

Fixes #691

Proposed Changes

  • e2e Test for user flag

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 29, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsmurugappan: 0 warnings.

In response to this:

Fixes #691

Proposed Changes

  • e2e Test for user flag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 29, 2020
@knative-prow-robot
Copy link
Contributor

Hi @itsmurugappan. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 29, 2020
@navidshaikh
Copy link
Collaborator

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 29, 2020
@navidshaikh
Copy link
Collaborator

/retest

    cli.go:70: ERROR: RevisionMissing: Configuration "testsvc0" does not have any ready Revision.

ref: logs

and

    --- FAIL: TestTrafficSplit/TagStagingLatest (6.77s)
        traffic_split_test.go:212: update tag from testing to staging for @latest revision
        traffic_split_test.go:419: assertion failed: 
            --- expectedTargets
            +++ formattedActualTargets
              []e2e.TargetFields{
              	{
            - 		Tag:      "staging",
            + 		Tag:      "testing",
              		Revision: "echo5-rev-1",
              		Percent:  100,
              		Latest:   true,
              	},
              }

ref: logs

another one for #694

@navidshaikh
Copy link
Collaborator

/retest

            🔥 RevisionMissing: Revision "echo0-rev-1" referenced in traffic not found.

Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsmurugappan, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2020
@itsmurugappan
Copy link
Contributor Author

/test pull-knative-client-integration-tests

@itsmurugappan
Copy link
Contributor Author

/test pull-knative-client-integration-tests-latest-release

@knative-prow-robot knative-prow-robot merged commit b95f40e into knative:master Feb 29, 2020
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
* make E2E_CLUSTER_PROJECT globally available

* add comment

* export E2E_CLUSTER_PROJECT

* fix CR issues

* remove readonly for two KO vars
@itsmurugappan itsmurugappan deleted the user-e2e branch May 25, 2020 15:36
mgencur pushed a commit to openshift-knative/client that referenced this pull request Nov 21, 2022
* Poke CI

* svc.ci -> ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e for --user flag
4 participants