Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wait): add sync revision delete operation #688

Merged
merged 1 commit into from
Feb 29, 2020
Merged

feat(wait): add sync revision delete operation #688

merged 1 commit into from
Feb 29, 2020

Conversation

dsimansk
Copy link
Contributor

Fixes #671

Proposed Changes

  • Change revision delete to wait for completion

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 26, 2020
knative-prow-robot
knative-prow-robot reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsimansk: 1 warning.

In response to this:

Fixes #671

Proposed Changes

  • Change revision delete to wait for completion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/serving/v1/client_mock.go
}

func (c *MockKnServingClient) DeleteRevision(name string) error {
call := c.recorder.r.VerifyCall("DeleteRevision", name)
func (c *MockKnServingClient) DeleteRevision(name string, timeout time.Duration) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Golint comments: exported method MockKnServingClient.DeleteRevision should have comment or be unexported. More info.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2020
@navidshaikh
Copy link
Collaborator

/retest

3 similar comments
@dsimansk
Copy link
Contributor Author

/retest

@navidshaikh
Copy link
Collaborator

/retest

@dsimansk
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2020
@dsimansk dsimansk force-pushed the revision-delete-wait branch from 594fa5d to 35b9f15 Compare February 27, 2020 12:56
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2020
@navidshaikh
Copy link
Collaborator

/retest

@dsimansk dsimansk force-pushed the revision-delete-wait branch from 35b9f15 to 62390e2 Compare February 28, 2020 11:40
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/revision/delete.go 76.5% 81.8% 5.3
pkg/serving/v1/client.go 74.7% 69.1% -5.5

@dsimansk dsimansk changed the title WIP: feat(wait): add sync revision delete operation feat(wait): add sync revision delete operation Feb 28, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2020
navidshaikh
navidshaikh approved these changes Feb 28, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Nice! Thanks for fixing this, this should reduce a number of flakes.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@navidshaikh
Copy link
Collaborator

/test pull-knative-client-integration-tests

@dsimansk
Copy link
Contributor Author

TrafficSplit fail

/test pull-knative-client-integration-tests

@navidshaikh
Copy link
Collaborator 

        🔥 RevisionMissing: Revision "hello-rsrfx-2" referenced in traffic not found.

@navidshaikh navidshaikh mentioned this pull request Feb 29, 2020
Closed
@navidshaikh
Copy link
Collaborator

/retest

This isn't flake with asynchronous revision delete, see #695

@navidshaikh
Copy link
Collaborator

/retest

    --- FAIL: TestTrafficSplit/TagStagingLatest (9.05s)

@navidshaikh
Copy link
Collaborator

/retest

--- FAIL: TestRevision (237.94s)

last retry, or lets get this in after #696

@knative-prow-robot knative-prow-robot merged commit b14dc2d into knative:master Feb 29, 2020
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@chaodaiG @knative-prow-robot
update all Prow components to latest version (knative#688)
ad06951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@navidshaikh navidshaikh navidshaikh approved these changes

@cppforlife cppforlife Awaiting requested review from cppforlife

Assignees

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --wait and --no-wait for all delete operation
5 participants
@dsimansk @navidshaikh @knative-metrics-robot @knative-prow-robot @googlebot