Harmonize list headers for trigger and sources #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/M
|
/test pull-knative-client-integration-tests |
rhuss
reviewed
Feb 12, 2020
pkg/kn/commands/flags/sink.go
Outdated
| if sink.Ref.Kind == "Service" { | ||
| return fmt.Sprintf("svc:%s", sink.Ref.Name) | ||
| } else { | ||
| return fmt.Sprintf("%s:%s", sink.Ref.Kind, sink.Ref.Name) |
There was a problem hiding this comment.
can we make the kind lower case ? That's how we use it normally.
There was a problem hiding this comment.
Done. covert to lower case in the latest version.
daisy-ycguo
force-pushed
the
updatelists
branch
from
804da04 to
a560c01
Compare
|
The following is the coverage report on the affected files.
|
|
thanks ! /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daisy-ycguo, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
* update boskos images and flags Fixed knative#638 * use images that exists also the most recent ones with the same tags
mgencur
pushed a commit
to openshift-knative/client
that referenced
this pull request
Nov 21, 2022
[release-v0.19.1] Fix deprecated registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567
Proposed Changes
SUBSCRIBER_URItoSINKin trigger listCONDITIONSto trigger listAGEto trigger and source ( cronjob, apiserver, binding ) listSinkToStringto packageflagsand reuse in trigger list