fix(serving): Add an error window for ReadyCondition #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A default error window of 2 seconds (not sure if this should be made configurable as it is hard to explain/document) cause return an error during sync operations only, if a ReadyCondition == false stays for that long in false. This is needed to compensate situation where the condition is false when a race between revision and route creation occurse during a service creation. This should fix the flakes we have in our E2E tests as described in knative#544.
knative-prow-robot
added
size/M
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Feb 8, 2020
rhuss
added a commit
to rhuss/knative-client
that referenced
this pull request
Feb 12, 2020
The error window introduced with knative#644 had a wrong conditional. Fixed that and added a test which would have detected this. Also, this should fix some issues which we tried to detect with knative#659.
knative-prow-robot
pushed a commit
that referenced
this pull request
Feb 13, 2020
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
…native#644) We are running code coverage on multiple repos and we are running it not only in pre-submit. Periodical jobs and post-submit jobs do not need the flag and it is distracting to set the defaultPostSubmitJobName, as it would be printed in logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A default error window of 2 seconds (not sure if this should be made configurable
as it is hard to explain/document) cause return an error during
sync operations only, if a ReadyCondition == false stays for that
long in false. This is needed to compensate situation where the
condition is false when a race between revision and route creation
occurse during a service creation.
This should fix the flakes we have in our E2E tests as described in #544.