"Faas" scenario — create a trigger alongside its source.

[sixolet]

This only so far handles the non-plugin source creation, but it's a start.

NB: based on #574 — MERGE THAT FIRST then rebase -i.

To do in this PR before merging:

• Add ceOverrides.knsourcetrigger / filter.knsourcetrigger matching attributes to both source and trigger.
• Create trigger before source.
• Add dependency attribute to trigger
• Add owner reference to source
• Add --async flag, and do an appropriate wait for readiness (ignore unready due to dependency not yet present)
• Tests
• Changelog

To do outside this PR:

• Merge PR Allow for http and broker sinks #574 for the broker allowed as a sink targer
• Make flag for ceOverrides setting in sources
• Make hidden flag for setting owner reference in sources.

Fixes #498

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/dynamic/client.go	90.9%	83.3%	-7.6
pkg/kn/commands/flags/sink.go	0.0%	78.3%	78.3
pkg/kn/commands/source/cronjob/create.go	92.0%	89.3%	-2.7
pkg/kn/commands/source/cronjob/update.go	75.8%	75.0%	-0.8
pkg/kn/commands/trigger/create.go	82.5%	67.3%	-15.2
pkg/kn/commands/trigger/update_flags.go	96.7%	96.8%	0.1
pkg/serving/service.go	90.6%	89.7%	-1.0

[knative-prow-robot]

@sixolet: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-knative-client-build-tests	7c71f0f	link	/test pull-knative-client-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rhuss]

@sixolet Is this PR ready for a review or would make it sense to review it later when more tasks from the list above are implemented ?

[sixolet]

It's still WIP

…

On Jan 7, 2020, at 2:59 AM, Roland Huß ***@***.***> wrote:  @sixolet Is this PR ready for a review or would make it sense to review it later when more tasks from the list above are implemented ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maximilien,sixolet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[maximilien]

You also need to rebase. Best.

[knative-prow-robot]

@sixolet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhuss]

@sixolet where do we stand with this PR ? Do you want to continue to work on this "FaaS" direction now replaced the direction the Functions WG is heading to ?

[rhuss]

@sixolet This PR needs probably a lot of love to be aligned with the main branch, so it's probably better to start afresh.

If you don't mind and if you don't have any objections until next Tuesday, I would close the PR then.

[rhuss]

Closing, for now, feel free to reopen in case.