fixes(#586): simplifies service update message to user #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash ➜ client git:(master) ✗ ./kn service update summary-fn --untag sync1 Using kn config file: /Users/maximilien/.kn/config.yaml Updating Service 'summary-fn' in namespace 'default': 0.089s Ready to serve. Service 'summary-fn' with latest revision 'summary-fn-nxqwb-41' (unchanged) is available at URL: http://summary-fn-default.kndemo-267179.sjc03.containers.appdomain.cloud ➜ client git:(master) ✗ ./kn service update summary-fn --image docker.io/drmax/summary-fn:latest Using kn config file: /Users/maximilien/.kn/config.yaml Updating Service 'summary-fn' in namespace 'default': 0.091s The Configuration is still working to reflect the latest desired specification. 6.317s Ready to serve. Service 'summary-fn' updated to latest revision 'summary-fn-jfjcy-42' is available at URL: http://summary-fn-default.kndemo-267179.sjc03.containers.appdomain.cloud ```
knative-prow-robot
added
the
size/XS
knative-prow-robot
added
the
approved
|
/test pull-knative-client-integration-tests |
|
@navidshaikh @rhuss can I get a quick review on this. Thanks |
rhuss
requested changes
Jan 7, 2020
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #586
Proposed Changes
This is a case when service is updated with tags and revision remained unchanged.
This is the case when service updated to new revision.
Release Note: