Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same flag definition for list command of list_type, service and route #582

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Use the same flag definition for list command of list_type, service and route #582

merged 1 commit into from
Dec 20, 2019

Conversation

daisy-ycguo
Copy link
Member

@daisy-ycguo daisy-ycguo commented Dec 20, 2019 •
edited
Loading

Proposed Changes

  • Remove redundant code for list flag definition under list_type, service and route
  • Use the same flag defined in listprint.go under pkg/kn/commands/flags for list command of list_type, service and route.
  • Rename the list flag from ListFlags to ListPrintFlags for better description.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 20, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2019
@daisy-ycguo
Copy link
Member Author

/test pull-knative-client-integration-tests

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/flags/listprint.go Do not exist 62.5%

rhuss
rhuss approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@knative-prow-robot knative-prow-robot merged commit d03cbf9 into knative:master Dec 20, 2019
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@ericKlawitter @knative-prow-robot
Increase serving test timeouts (knative#582)
91c8ce0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daisy-ycguo @knative-metrics-robot @knative-prow-robot @rhuss @googlebot