Update deps using go 1.13 #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
navidshaikh
force-pushed
the
pr/golang-113
branch
from
cf9499d to
ce5f1b1
Compare
|
/hold We'll need changes at test-infra side for using go 1.13 for client tests. |
knative-prow-robot
added
the
do-not-merge/hold
|
Related/dependency: knative/test-infra#1558 |
navidshaikh
force-pushed
the
pr/golang-113
branch
from
ce5f1b1 to
334e2ba
Compare
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
navidshaikh
force-pushed
the
pr/golang-113
branch
from
334e2ba to
82a588c
Compare
knative-prow-robot
added
size/M
navidshaikh
force-pushed
the
pr/golang-113
branch
from
82a588c to
692345a
Compare
knative-prow-robot
added
size/XXL
|
FYI Prow job for client has been updated to use Go 1.13, so this PR is now ready to be merged. |
- Commit results of codegen using go 1.13 - Update DEVELOPMENT.md to mention go 1.13
navidshaikh
force-pushed
the
pr/golang-113
branch
from
692345a to
61ea017
Compare
|
/lgtm |
dsimansk
pushed a commit
to dsimansk/client
that referenced
this pull request
Nov 28, 2024
…y providing goos and goarch. (knative#535) * add go build with goos and goarch * add a example at help message --------- Co-authored-by: Kaustubh Pande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532
Proposed Changes