In waiting for ready, watch falls back to polling. #491
Conversation
There was a problem hiding this comment.
@sixolet: 3 warnings.
In response to this:
Fixes #325
Add a new way of using a polling function to generate a watch.Interface(), and fall back to that if the server doesn't support watch. Not every knative server supports watch.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
size/L
|
The test issue is some |
|
@sixolet please rebase on master, I've fixed that. |
|
/retest |
1 similar comment
|
/retest |
| Type: watch.Added, | ||
| Object: new, | ||
| } | ||
| } else if !(ok1 && ok2) { |
There was a problem hiding this comment.
Should we separate the if check for err, ok1 and ok2 ? (OR may be a nested switch)
There was a problem hiding this comment.
I tried it that way, and it was less clear and more error prone, so I returned it to this way.
|
/retest |
|
The following is the coverage report on the affected files.
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
while setting up serving/eventing
Fixes #325
Add a new way of using a polling function to generate a watch.Interface(), and fall back to that if the server doesn't support watch. Not every knative server supports watch.