Adds zsh completion #476
Adds zsh completion #476
Conversation
- Adds back zsh completion after vendoring cobra library with a fix - Updates the command definition to accept argument either of ['bash', 'zsh'] - Moves the completion command definition under `pkg/kn/commands/completion` - Updates docs - Updates CHANGELOG.adoc
There was a problem hiding this comment.
@navidshaikh: 1 warning.
In response to this:
Fixes #456
Proposed Changes
- Adds back zsh completion after vendoring cobra library with a fix
- Updates the command definition to accept argument either of ['bash', 'zsh']
- Moves the completion command definition under
pkg/kn/commands/completion- Updates docs
- Updates CHANGELOG
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
size/L
|
/lint |
There was a problem hiding this comment.
@navidshaikh: 0 warnings.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
The following is the coverage report on the affected files.
|
|
Looks good to me. I added #477 to not forget that we should reintroduce the completion command to the help message, too (or at least discuss this). /lgtm |
|
/retest |
* let 0 statement go file pass coverage threshold 1. Go file with no statement should not be marked as low coverage file. 2. Added logs when a file is marked as low coverage file. This will help debugging to see if a file is marked wrongly * add more comments
Co-authored-by: David Simansky <[email protected]>
Fixes #456
Proposed Changes
pkg/kn/commands/completion/lint