Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependencies to Eventing 0.10.0 #470

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Add dependencies to Eventing 0.10.0 #470

merged 1 commit into from
Nov 12, 2019

Conversation

daisy-ycguo
Copy link
Member

@daisy-ycguo daisy-ycguo commented Nov 1, 2019 •
edited
Loading

Proposed Changes

  • Add dependencies to Eventing v0.10.0

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 1, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 1, 2019
maximilien
maximilien approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to verify this dependency in a e2e test? For instance, nothing complicated. Maybe checking version? Just curious.

BTW, thx for splitting the dependency into its own PR. Best.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2019
@maximilien
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 1, 2019
@daisy-ycguo daisy-ycguo force-pushed the eventdepend branch 3 times, most recently from 712ec5a to 3b7881d Compare November 4, 2019 09:13
@daisy-ycguo daisy-ycguo changed the title Add dependencies to Eventing 0.10.0 Add dependencies to Eventing 0.0.0 Nov 4, 2019
@daisy-ycguo daisy-ycguo changed the title Add dependencies to Eventing 0.0.0 Add dependencies to Eventing 0.9.0 Nov 4, 2019
@daisy-ycguo daisy-ycguo mentioned this pull request Nov 4, 2019
Closed
@daisy-ycguo daisy-ycguo force-pushed the eventdepend branch 2 times, most recently from 76a6cdc to 432bd9d Compare November 4, 2019 10:16
@maximilien
Copy link
Contributor

Seems like you need to rebase @daisy-ycguo

@daisy-ycguo daisy-ycguo changed the title Add dependencies to Eventing 0.9.0 Add dependencies to Eventing 0.10.0 Nov 5, 2019
@daisy-ycguo
Copy link
Member Author

/retest

@daisy-ycguo
Copy link
Member Author

@rhuss and @maximilien It's ready for review now. Thank you.

@rhuss
Copy link
Contributor

rhuss commented Nov 5, 2019

/hold

Let's wait until 0.10.0 has landed, then we have 6 weeks to ramp up eventing for 0.11.0

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2019
rhuss
rhuss approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhuss
Copy link
Contributor

rhuss commented Nov 11, 2019

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2019
@rhuss
Copy link
Contributor

rhuss commented Nov 11, 2019

@daisy-ycguo this PR looks good to me, but needs a rebase and conflict resolution. Happy to merge tomorrow when the conflict is resolved.

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@rhuss
Copy link
Contributor

rhuss commented Nov 12, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@knative-prow-robot knative-prow-robot merged commit d66887a into knative:master Nov 12, 2019
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@chaodaiG @knative-prow-robot
update release yaml path from build (knative#470)
9c32cdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@maximilien maximilien maximilien approved these changes

@cppforlife cppforlife Awaiting requested review from cppforlife

@navidshaikh navidshaikh Awaiting requested review from navidshaikh

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daisy-ycguo @maximilien @rhuss @knative-prow-robot @googlebot