Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds kn nightly and latest release image URL in docs #466

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

navidshaikh
Copy link
Collaborator

Proposed Changes

  • Nightly: gcr.io/knative-nightly/knative.dev/client/cmd/kn
  • Latest release: gcr.io/knative-releases/knative.dev/client/cmd/kn

 * Nightly: `gcr.io/knative-nightly/knative.dev/client/cmd/kn`
 * Latest release: `gcr.io/knative-releases/knative.dev/client/cmd/kn`
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 31, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2019
@navidshaikh
Copy link
Collaborator Author

Related to #465

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a269d29 into knative:master Oct 31, 2019
@navidshaikh navidshaikh deleted the pr/kn-image-path branch October 31, 2019 09:01
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
…g Github issues tracking (knative#466)

* Add ghutil package for supporting Github issues tracking

This package is a wrapper of 'github.com/google/go-github/github',  handles authentication, issues, comments related helper functions, with logic of retry and depagination.

All apis declared in this package wil later on be used for issues tracking of flaky tests, includes listing/creating/closing/reopening issues and listing/creating/editing comments, and adding/removing labels

* resolving comments

* Update tools/flaky-test-reporter/ghutil/ghutil.go

Co-Authored-By: chaodaiG <[email protected]>
matejvasek pushed a commit to matejvasek/client that referenced this pull request Nov 5, 2024
* [release-v1.14] Update func to latest midstream

* Update S-O branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants