-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Docs #421
Restructure Docs #421
Conversation
/assign @navidshaikh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. Let's give this until Monday so others have time to chime in.
Also, I have a couple of PRs pending adding docs for config #411 and plugins #320. There are some pending comments. Please chime in as well since depending on order of which gets merged you or I may have to rebase. Should not be too hard either way but still stuff todo :)
Thanks for your contribution @joaedwar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are few TODOs which we can fill in subsequent PRs. As there are other docs PR open, would like to get this structure merged and have other PRs follow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and we can refine it later again, too.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaedwar, navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #
Issue 381
Proposed Changes