Retain the request body when logging HTTP.

[Harwayne]

Fixes #377

Proposed Changes

• Retain the request body when logging HTTP.

Release Note

--log-http now works for requests with a body.

[knative-prow-robot]

@Harwayne: 0 warnings.

In response to this:

Fixes #377

Proposed Changes

• Retain the request body when logging HTTP.

Release Note

--log-http now works for requests with a body.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[navidshaikh]

Looks good to me.
/assign @sixolet

[maximilien]

Can we have a few tests for this?

[Harwayne]

Can we have a few tests for this?

Done.

[knative-metrics-robot]

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/util/logging_http_transport.go	92.6%	86.7%	-5.9

[sixolet]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sixolet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment