Fix json path to latest revision in e2e tests to something reliable #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
approved
navidshaikh
approved these changes
Aug 20, 2019
| @@ -35,7 +35,7 @@ var targetFieldsLength = 4 | |||
| var targetsJsonPath = "jsonpath={range .status.traffic[*]}{.tag}{','}{.revisionName}{','}{.percent}{','}{.latestRevision}{'|'}{end}" | |||
|
|
|||
| // returns deployed service latest revision name | |||
| var latestRevisionJsonPath = "jsonpath={.status.traffic[?(@.latestRevision==true)].revisionName}" | |||
| var latestRevisionJsonPath = "jsonpath={.status.latestCreatedRevisionName}" | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
* A helper funcion for removing broken symlinks Two types of symlinks are considered broken: 1. Broken symlinks. 2. Symlinks pointing to a path outside of the source tree. This function was impleneted in knative/serving#2842 and should be useful for all knative modules. * Readd LF at end of file after merge
dsimansk
pushed a commit
to dsimansk/client
that referenced
this pull request
May 28, 2020
as the test-infra scripts are no longer under vendor dir but at the root of repo
dsimansk
pushed a commit
to dsimansk/client
that referenced
this pull request
May 15, 2024
…y providing goos and goarch. (knative#376) * add go build with goos and goarch * add a example at help message --------- Co-authored-by: Kaustubh Pande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small change that should make a helper function in the tests reliably return the latest revision name even when traffic doesn't have anything set to latest. No change to the actual running of the tests.