docs: References golang 1.12.7 or later in docs #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
|
Not sure if 1.12.7 specifically is required or if 1.12 in general is enough. I would omit the patchlevel from the version |
|
The page https://golang.org/dl/ we're referencing for downloading golang has listing of (only) 1.12.7 in |
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
|
We then would have to upgrade our docs for every patch level version then. Still, think that 1.12 is good enough to mention (and if there is only 1.12.7 to download, then fine, but people with 1.12.3 still can compile it, I think). Nit-picking on high-level though, I'm fine with either. |
Fix knative#353 As we require minimum 1.12.x for building kn
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
|
/lgtm |
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
* webhook based API-Coverage tool: webhook setup This changeset adds the webhook package that provides helper method to setup the webhook required by the tool. Webhook setup is generic so that it can be called by any repo providing its own implementation of the web-server. * Update tools/webhook-apicoverage/webhook/webhook.go Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]> * Update tools/webhook-apicoverage/webhook/README.md Co-Authored-By: dushyanthsc <[email protected]>
dsimansk
added a commit
to dsimansk/client
that referenced
this pull request
Feb 22, 2024
…e#355) * [release-v1.11] switch RHBQ version in workflow plugin config * [release-v1.11] fix package name in ldflags * Fix dev image tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
As we require minimum 1.12.7 for building kn