-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap flag usage to terminal size #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ;-) I wonder whether we should also add wrapping code for wide columns like the REASON in services list
.
As you said, it's weird to include an ssh library for getting this functionality.
However, the alternatives like https://github.com/gdamore/tcell or https://github.com/nsf/termbox-go seems to be overkill for what we need here.
Some questions on dependencies, but otherwise fine.
The following is the coverage report on pkg/.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhuss, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's weird that the most idiomatic library to go get a term size is in a crypto lib, but it's not actually that bad of a dep and greatly improves the experience on a smaller-width terminal.
We don't bother to wrap if there's no gettable terminal size.