List revisions sorted by configuration generation

[toVersus]

/lint
Fixes #289

Proposed Changes

• Use number of configuration generation as a sort key, which is obtained from a label on the configuration resource.
• Introduce GENERATION column referred from number of configuration generation.
• Example output:

List all revisions

$ ./kn revision list
NAME          SERVICE   GENERATION   AGE   CONDITIONS   READY   REASON
echo-qfftl    echo      3            22h   4 OK / 4     True
hello-cjdcn   hello     3            22h   3 OK / 4     True
hello-d55vd   hello     2            22h   3 OK / 4     True
hello-hjxjw   hello     1            22h   3 OK / 4     True

Filter by service name

$ ./kn revision list -s hello
NAME          SERVICE   GENERATION   AGE   CONDITIONS   READY   REASON
hello-cjdcn   hello     3            22h   3 OK / 4     True
hello-d55vd   hello     2            22h   3 OK / 4     True
hello-hjxjw   hello     1            22h   3 OK / 4     True

[knative-prow-robot]

@toVersus: 0 warnings.

In response to this:

/lint
Fixes #289

Proposed Changes

• Use number of configuration generation as a sort key, which is obtained from a label on the configuration resource.
• Introduce ORDER column referred from number of configuration generation.
• Example output:

List all revisions

$ ./kn revision list
NAME          SERVICE   ORDER   AGE    CONDITIONS   READY   REASON
echo-qfftl    echo      3       8h     4 OK / 4     True
hello-cjdcn   hello     3       8h     3 OK / 4     True
echo-mjx47    echo      2       2d4h   4 OK / 4     True
hello-d55vd   hello     2       8h     3 OK / 4     True
hello-hjxjw   hello     1       8h     3 OK / 4     True

Filter by service name

$ ./kn revision list -s hello
NAME          SERVICE   ORDER   AGE   CONDITIONS   READY   REASON
hello-cjdcn   hello     3       8h    3 OK / 4     True
hello-d55vd   hello     2       8h    3 OK / 4     True
hello-hjxjw   hello     1       8h    3 OK / 4     True

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Hi @toVersus. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhuss]

/ok-to-test

[rhuss]

except for one minor details looks good to me.

[rhuss]

@toVersus ah, and yes, could you please update the top-level CHANGELOG.adoc, too with this fix ?

[toVersus]

@rhuss, thanks for your review! I addressed your comments and also updated CHANGELOG.adoc.

[knative-metrics-robot]

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/revision/human_readable_flags.go	94.7%	95.0%	0.3
pkg/kn/commands/revision/revision_list.go	85.7%	85.2%	-0.5

[rhuss]

Thanks !

/approve
/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss, toVersus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment