Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use knative.dev/test-infra #319

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

chaodaiG
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 31, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 31, 2019
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@knative-prow-robot knative-prow-robot merged commit 9f203f2 into knative:master Jul 31, 2019
maximilien pushed a commit to maximilien/client that referenced this pull request Jul 31, 2019
navidshaikh added a commit to navidshaikh/client that referenced this pull request Apr 8, 2020
* Update SPEC file, version tar name, unversioned dir name

 - tar file name is now version
 - the dir in the tar is now unversioned

* SPEC file is now propogated in release-* branches

 This is to ensure zero delta between midstream and downstream.
 Also syncing release-next branch for nightly downstreams.
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
The previous definitions don't work with bazel 0.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants