fix: Fix error when no current namespace is set #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no current namespace is set in the config file, then using `kn` without -n fails: ``` invalid configuration: no configuration has been provided ``` Instead of failing in this case, assume the default namespace "namespace"
knative-prow-robot
added
the
approved
knative-prow-robot
added
the
size/XS
|
The following is the coverage report on pkg/.
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maximilien
pushed a commit
to maximilien/client
that referenced
this pull request
Jul 31, 2019
When no current namespace is set in the config file, then using `kn` without -n fails: ``` invalid configuration: no configuration has been provided ``` Instead of failing in this case, assume the default namespace "namespace"
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
* Instead of deleting the images in GCR after the test finishes, have a job to perform it from time to time (and only old images). Add cleanup.sh script under tools Add unit testing under test/unit Add Prow job calling this cleanup script periodically Remove delete_gcr_images function from common library.sh Refactor some common functions to library After this PR, scripts/functions for images deletions will only live under knative/test-infra repo, and no jobs other than cleanup-old-images job should delete any images. * update cleanup script path in prow config.yaml file * simplify code, improve readability, better documentation based on Adriano's CR feedback on github * fixing typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no current namespace is set in the config file, then using
knwithout -n fails:Instead of failing in this case, assume the default namespace "namespace"