Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves(e2e): improves integration tests and to better run locally #274

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Improves(e2e): improves integration tests and to better run locally #274

merged 3 commits into from
Jul 23, 2019

Conversation

maximilien
Copy link
Contributor

@maximilien maximilien commented Jul 18, 2019 •
edited
Loading

Improves integration tests and to better run locally

Fixes #273

Proposed Changes

  • refactors basic workflow (move some code to common)
  • use different namespace for each test to isolate
  • include wait logic in CreateNamespace to allow multiple runs
  • include wait logic in DeleteNamespace to allow multiple runs

Release Note

Important since we need more integration tests overall for kn and some of
these changes should allow `./test/e2e-tests-local.sh` to run on
local clusters (minikube or something other than test-infra) and
correctly behave during multiple runs.

@maximilien
Improves(e2e): imrpoves integration tests and to better run locally
0ba7d2c 
1. refactors basic workflow (move code to common)
2. use different namespace accross test runs to isolate
3. include wait logic in CreateNamespace to allow multiple runs
4. include wait logic in DeleteNamespace to allow multiple runs

This is important since we need more integration tests and some of
these changes should allow `./test/e2e-tests-local.sh` to run on
local clusters (minikube or something other than test-infra) and
correctly behave during mutiple runs.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 18, 2019
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2019
rhuss
rhuss requested changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You (accidentally ?) reverted one of the last commits. Please revert the revert ;-)
  • The login for creating the namespace with retries is broken imo. Please check.
  • To avoid boolean flags I suggest a different approach (see comments)

test/e2e/basic_workflow_test.go Outdated Show resolved Hide resolved
test/e2e/basic_workflow_test.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
@maximilien
Copy link
Contributor Author

maximilien commented Jul 19, 2019 •
edited
Loading

OK see update @rhuss. I need this merged before #249 get completed and pushed. Thx.

@maximilien
Copy link
Contributor Author

/test pull-knative-client-integration-tests-latest-release

@maximilien maximilien mentioned this pull request Jul 19, 2019
Merged
rhuss
rhuss approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhuss
Copy link
Contributor

rhuss commented Jul 22, 2019

Fails because of async update, fixed with #271 . The test should be fixed as soon as this PR is merged.

Nevertheless, trying
/retest

@maximilien
Copy link
Contributor Author

OK thx @rhuss I see #271 is merged. I will rebase and push this again. Hopefully along with update for #249

@maximilien maximilien mentioned this pull request Jul 22, 2019
Merged
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@maximilien
Copy link
Contributor Author

OK updated @rhuss. Let's see if all tests go green

@rhuss
Copy link
Contributor

rhuss commented Jul 23, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@knative-prow-robot knative-prow-robot merged commit 9513ded into knative:master Jul 23, 2019
@maximilien maximilien deleted the improve-it branch December 20, 2019 02:17
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@adrcunha @knative-prow-robot
Don't run E2E tests if DOCKER_REPO_OVERRIDE is the release GCR (knati…
defbe8e 
…ve#274)
dsimansk added a commit to dsimansk/client that referenced this pull request Oct 3, 2023
@dsimansk
Fix plugin inlining that uses client-pkg dependency (knative#1816) (k…
8fb64c0 
…native#274)

* Fix plugin inlining that uses client-pkg dependency

* Move list merge into plugin manager

* Fix imports formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@cppforlife cppforlife Awaiting requested review from cppforlife

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky e2e local tests
4 participants
@maximilien @knative-prow-robot @rhuss @googlebot