Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the periodic CI flow error in client #200

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Fix the periodic CI flow error in client #200

merged 2 commits into from
Jun 27, 2019

Conversation

chizhg
Copy link
Member

@chizhg chizhg commented Jun 23, 2019

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 23, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2019
@adrcunha
Copy link
Contributor

I think this is overkill: 316 files and 50K lines just for a flag. -emitmetrics is not used in the e2e tests, so just define it as a no-op flag and add an appropriate comment.

@chizhg chizhg force-pushed the SolveCIFlowError branch from 8360fed to fbba466 Compare June 23, 2019 20:45
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 23, 2019
@chizhg chizhg force-pushed the SolveCIFlowError branch from fbba466 to 248f5ca Compare June 23, 2019 20:51
@adrcunha
Copy link
Contributor

/test pull-knative-client-build-tests

@adrcunha
Copy link
Contributor

Ugh, looks like the build job is affected by knative/test-infra#1018

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2019
@adrcunha
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2019
@adrcunha
Copy link
Contributor

/assign @sixolet

maximilien
maximilien reviewed Jun 25, 2019
View reviewed changes
test/e2e/e2e_flags.go Outdated
)

// ClientFlags saves the environment flags for client.
var ClientFlags = initializeFlags()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does doing this fix the CI flow errors? Is there something missing in this PR? Or perhaps elaborate the problem and fix. Thx

Copy link
Member Author

@chizhg chizhg Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emitmetrics is a flag used by our testing framework, which is also required for the running of periodic jobs. But since Knative client is not using the framework, it does not have the flag, so adding this flag as a no-op can solve the error.
I have made it a bit simpler and added more meaningful comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not obvious but thanks for the explanation. Hopefully fixes things. Thanks.

@chizhg chizhg force-pushed the SolveCIFlowError branch from 168eef0 to fd28ccb Compare June 25, 2019 18:29
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@rhuss
Copy link
Contributor

rhuss commented Jun 27, 2019

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, Fredy-Z, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@knative-prow-robot knative-prow-robot merged commit 483979b into knative:master Jun 27, 2019
@chizhg chizhg deleted the SolveCIFlowError branch June 29, 2019 02:31
maximilien pushed a commit to maximilien/client that referenced this pull request Jul 1, 2019
@chizhg @maximilien
Fix the periodic CI flow error in client (knative#200)
0f7fd43 
* hack the emitmetrics flag

* update test-infra
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@adrcunha @knative-prow-robot
Cleanup bazel after library-tests.sh finish (knative#200)
0018e4f 
Otherwise Gubernator will report failures, even when all tests pass, because some tests do test that testcases failed (!).
Kaustubh-pande pushed a commit to Kaustubh-pande/client that referenced this pull request Jul 12, 2023
@dsimansk
[release-v1.9] Update func to v1.10.1 (knative#200)
0f90cab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien left review comments

@adrcunha adrcunha Awaiting requested review from adrcunha

Assignees

@rhuss rhuss

@sixolet sixolet

@adrcunha adrcunha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chizhg @adrcunha @rhuss @knative-prow-robot @maximilien @sixolet @googlebot