fix(build.sh): Cosmetic spacing fix #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterm has an issue with rendering multi byte unicode chars. This commit adds an extra space to certain emojis on iterm only. This fixes current rendering issues on Linux term because that extra space was added previously unconditionally.
knative-prow-robot
added
the
size/S
|
Alternatively the icons could be exchanged to emoji which work every where (smaller unicode points) |
|
/retest |
|
adrcunha
reviewed
Jun 24, 2019
| @@ -25,6 +25,11 @@ fi | |||
|
|
|||
| set -eu | |||
|
|
|||
| # Temporary fix for iTerm issue https://gitlab.com/gnachman/iterm2/issues/7901 | |||
There was a problem hiding this comment.
I suggest replacing the 4 lines with
[[ -n "${ITERM_PROFILE:-}" ]] S=" " || S=""
There was a problem hiding this comment.
Updated but kept the if-syntax although a bit more terse but easier to understand for non-shell gurus.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cppforlife, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
maximilien
pushed a commit
to maximilien/client
that referenced
this pull request
Jul 1, 2019
* fix(build.sh): Cosmetic spacing fix Iterm has an issue with rendering multi byte unicode chars. This commit adds an extra space to certain emojis on iterm only. This fixes current rendering issues on Linux term because that extra space was added previously unconditionally. * fix(build.sh): Avoid uninitialized variable ITERM_PROFILE
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
* Scripts can customize the behavior by providing their own function, plus pre/post actions. Part of knative#101. Bonuses: * moved documentation to README * added basic tests for the feature * moved the helper tests to a separate directory for clarity * refactored checking if a function exists into a function * test-infra presubmit now uses the default integration test runner * Replace last instance of "type -t" * Make custom flag smoke test a unit test * Explain test objective
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterm has an issue with rendering multi byte unicode chars. This
commit adds an extra space to certain emojis on iterm only.
This fixes current rendering issues on Linux term because that extra
space was added previously unconditionally.