-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Dedup code by using client-pkg #1935
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go.mod
Outdated
// TODO: remove when https://github.com/knative/client-pkg/pull/177 is merged | ||
replace knative.dev/client-pkg => github.com/cardil/knative-client-pkg v0.0.0-20240416095801-87f6a5d7889a | ||
|
||
//replace knative.dev/client-pkg => ../knative-client-pkg | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Wait for knative/client-pkg#177
9ef3520
to
e1ac74f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
==========================================
+ Coverage 74.58% 78.03% +3.45%
==========================================
Files 207 141 -66
Lines 15567 8770 -6797
==========================================
- Hits 11611 6844 -4767
+ Misses 3167 1271 -1896
+ Partials 789 655 -134 ☔ View full report in Codecov by Sentry. |
2acd056
to
e032562
Compare
e032562
to
d993c96
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold I think, I'll reconsider this in favor of another idea - to integrate all client code within knative/client itself, but with go modules. Probably some changes are needed for the release script, and some adjustment for Go 1.22 vendor changes, see: golang/go#60056 |
This Pull Request is stale because it has been open for 90 days with |
Changes
Reference
Fixes knative-extensions/kn-plugin-event#282