Fix for file not found error message discrepancy in windows #1575
Conversation
There was a problem hiding this comment.
@vyasgun: 0 warnings.
In response to this:
Description
Added file not found error check for windows specific message
Changes
- Added windows-specific string for non-existent file tests
Reference
Fixes #
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
size/S
|
Pls rerun |
|
|
||
| func fileNotFoundErrorCheck(out test.KnRunResult, filePath string) cmp.Comparison { | ||
| result := util.ContainsAllIgnoreCase(out.Stderr, "no", "such", "file", "directory", filePath) | ||
| if result() == cmp.ResultSuccess { |
There was a problem hiding this comment.
I wonder if that shouldn't be rather == windows check. Well the comment should be a few lines below. :)
There was a problem hiding this comment.
I added a comment for clarity
|
@vyasgun should be used here as well. https://github.com/knative/client/blob/main/test/e2e/service_import_test.go#L93 |
vyasgun
force-pushed
the
pr/windows-test-fix
branch
from
24cb7f9 to
5a481af
Compare
|
@dsimansk I called the same function in the service_import_test.go file |
vyasgun
force-pushed
the
pr/windows-test-fix
branch
from
a40c8c8 to
7f14d15
Compare
I see now, sorry my bad. I kind of haven't noticed it's another file. :) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
…1575) * Fix for file not found error message discrepancy in windows * Added comment
…1575) (#967) * Fix for file not found error message discrepancy in windows * Added comment Co-authored-by: Gunjan Vyas <[email protected]>
Fix for file not found error message discrepancy in windows (knative#1575) (#967) Co-authored-by: Gunjan Vyas <[email protected]> change display versions (knative#1601) (#985) Co-authored-by: kobayashi <[email protected]>
Description
Added file not found error check for windows specific message
Changes
Reference
Fixes #