-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: Change default to server-side generated revision names #1236
update: Change default to server-side generated revision names #1236
Conversation
/retest |
@rhuss E2E will need updates as well. This test fails due to "same change" isn't generating new revision. I'll look into a bit to spot other issues. Missing revision name in Changing service visibility doesn't produce new revision also.
https://github.com/knative/client/blob/master/test/e2e/service_test.go#L96-L99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Interesting that there is a timeout. Regardless what, that should never happen. |
Indeed the timeout is caused by out waiting function. In case of executing same First successful update ➜ client git:(pr/switch-to-server-generated-revision-names-by-default) ✗ kn service update hello --env TARGET="v2"
Updating Service 'hello' in namespace 'default':
Event type: ADDED
Event type: MODIFIED
0.058s The Configuration is still working to reflect the latest desired specification.
Event type: MODIFIED
Event type: MODIFIED
5.835s Traffic is not yet migrated to the latest revision.
Event type: MODIFIED
5.891s Ingress has not yet been reconciled.
Event type: MODIFIED
5.947s Waiting for load balancer to be ready
Event type: MODIFIED
6.112s Ready to serve.
Service 'hello' updated to latest revision 'hello-00002' is available at URL:
http://hello.default.example.com
The second one blocked waiting: ➜ client git:(pr/switch-to-server-generated-revision-names-by-default) ✗ kn service update hello --env TARGET="v2"
Updating Service 'hello' in namespace 'default':
Event type: ADDED With my naive fix as an example. @@ -177,6 +177,13 @@ func (w *waitForReadyConfig) waitForReadyCondition(watcher watch.Interface, star
// resource version. All following watch events are for all changes that occurred after the resource
// version the watch started at."
if event.Type != watch.Modified {
+ inSync, err := generationCheck(event.Object)
+ if err != nil {
+ return false, false, err
+ }
+ if inSync {
+ return false, false, nil
+ }
continue
} Update is "instantly" executed. ➜ client git:(pr/switch-to-server-generated-revision-names-by-default) ✗ kn service update hello --env TARGET="v2"
Updating Service 'hello' in namespace 'default':
Event type: ADDED
0.003s Ready to serve.
Service 'hello' with latest revision 'hello-00002' (unchanged) is available at URL:
http://hello.default.example.com |
…are already in sync
/hold On some local tests I have issues with the wait loop |
The following is the coverage report on the affected files.
|
@maximilien @dsimansk would need a lgtm here to get it merged /unhold |
🤞 |
/retest |
1 similar comment
/retest |
/hold |
@rhuss: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Close, fixed by #1240 |
@rhuss: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #1144