Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix deprecated terminal lib #1215

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix: Fix deprecated terminal lib #1215

merged 1 commit into from
Feb 5, 2021

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Feb 5, 2021

Description

Fix deprecated module to make linter happy.

Changes

  • Change terminal module from golang.org/x/crypto to golang.org/x/term

Reference

#1207 (comment)

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 5, 2021
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 5, 2021
maximilien
maximilien approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Feb 5, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@knative-prow-robot knative-prow-robot merged commit 1499be9 into knative:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsimansk @knative-prow-robot @maximilien