[release-0.18] Backport #1083 #1113 #1138

navidshaikh · 2020-11-25T07:22:02Z

Backport PR for release-v0.18.4 with

Cross-compile the kn binary for linux/s390x #1083
Fix race conditions when creating watches #1113
Updated CHANGELOG

google-cla · 2020-11-25T07:22:07Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

navidshaikh · 2020-11-25T07:22:30Z

@BbolroC : can you please add your consent by adding comment @googlebot I consent. here ?

google-cla · 2020-11-25T07:22:35Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-25T07:22:46Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

navidshaikh · 2020-11-25T07:23:34Z

hack/release.sh

+  echo "🚧 Z  Building for Linux(s390x)"
+  GOOS=linux GOARCH=s390x go build -mod=vendor -ldflags "${ld_flags}" -o ./kn-linux-s390x ./cmd/...
  echo "🚧 🐳 Building the container image"
  ko resolve --strict ${KO_FLAGS} -f config/ > kn-image-location.yaml
-  ARTIFACTS_TO_PUBLISH="kn-darwin-amd64 kn-linux-amd64 kn-windows-amd64.exe kn-image-location.yaml"
-  if type sha256sum >/dev/null 2>&1; then
-    echo "🧮     Checksum:"
-    sha256sum ${ARTIFACTS_TO_PUBLISH}
-  fi
+  ARTIFACTS_TO_PUBLISH="kn-darwin-amd64 kn-linux-amd64 kn-linux-arm64 kn-windows-amd64.exe kn-linux-s390x kn-image-location.yaml"
+  sha256sum "${ARTIFACTS_TO_PUBLISH}" > checksums.txt
+  ARTIFACTS_TO_PUBLISH="${ARTIFACTS_TO_PUBLISH} checksums.txt"
+  echo "🧮     Checksum:"
+  cat checksums.txt


/cc @rhuss
PTAL

BbolroC · 2020-11-25T07:58:12Z

@googlebot I consent

google-cla · 2020-11-25T07:58:17Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

rhuss

/lgtm
/approve
/hold

knative-prow-robot · 2020-11-25T08:19:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [navidshaikh,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhuss · 2020-11-25T08:22:11Z

Not sure why @googlebot still doesn't like it.

If everything breaks, I found out that if you squash the PR manually then you can get over this. However this will loose the history of the commit

google-cla · 2020-11-25T08:22:25Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

rhuss · 2020-11-25T08:23:43Z

@BbolroC could you please comment @googlebot I consent. (mind the trailing dot, that you forgot on your fist comment). Thx!

google-cla · 2020-11-25T08:23:48Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

BbolroC · 2020-11-25T08:31:47Z

@googlebot I consent.

google-cla · 2020-11-25T08:31:52Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-25T08:32:20Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

navidshaikh · 2020-11-25T08:44:17Z

@googlebot I consent.

google-cla · 2020-11-25T08:44:22Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

navidshaikh · 2020-11-25T08:48:37Z

@rhuss : looks like it commit has apparently another person as co-author whose github id no longer exists 🤔

rhuss · 2020-11-25T08:54:43Z

@navidshaikh ok, in this case I suggest that you squash all commits locally on your branch and then force push it to this PR. That's the easiest way to overcome the CLA bot (which is stupid that he doesn't detect that these commits has been already consented in a different branch)

navidshaikh · 2020-11-25T09:31:39Z

there are two separate emails @ gmail and @ ibm.com of @BbolroC which seems to confuse the bot

commit 44d9f14f9f96f35a6daeebd276cf3d1d8ed3e918
Author: Hyounggyu Choi <[email protected]>
Date:   Tue Nov 24 20:51:35 2020 +0100

    Cross-compile the kn binary for linux/s390x (#1083)
    
    Co-authored-by: Hyounggyu Choi <[email protected]>

navidshaikh · 2020-11-25T09:34:39Z

@rhuss : I edited the commit and reset its author to keep the history, ➜ client git:(44d9f14f) git commit --amend --reset-author
bot is happy now :-)

BbolroC · 2020-11-25T09:50:38Z

I will keep this in mind and never make the bot confused again. Thank @navidshaikh for the care.

* Fix a race condition between creating a watch and initiating the action that emits the event it is watching for * update changelog * add PR ID to changelog entry * Fix merge in Changelog * Fix table format in Changelog

knative-metrics-robot · 2020-11-25T13:30:58Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/eventing/v1beta1/client.go	85.8%	86.9%	1.1
pkg/serving/v1/client.go	64.5%	65.8%	1.3

rhuss · 2020-11-25T13:54:39Z

/lgtm

navidshaikh · 2020-11-25T13:55:51Z

/unhold

navidshaikh · 2020-11-25T14:37:13Z

/retest

    result_collector.go:75: ERROR: Error: Operation cannot be fulfilled on pingsources.sources.knative.dev "testpingsource0": the object has been modified; please apply your changes to the latest version and try again

google-cla bot added the cla: no Indicates the PR's author has not signed the CLA. label Nov 25, 2020

knative-prow-robot requested review from maximilien and rhuss November 25, 2020 07:22

knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2020

navidshaikh commented Nov 25, 2020

View reviewed changes

rhuss reviewed Nov 25, 2020

View reviewed changes

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020

knative-prow-robot assigned rhuss Nov 25, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020

Cross-compile the kn binary for linux/s390x (knative#1083)

1bdd7af

Update CHANGELOG for kn v0.18.4

75d5fbe

navidshaikh force-pushed the rel/v0.18.4 branch from c9a03e4 to 75d5fbe Compare November 25, 2020 09:33

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020

google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Nov 25, 2020

Fix race conditions when creating watches (knative#1113)

f158303

* Fix a race condition between creating a watch and initiating the action that emits the event it is watching for * update changelog * add PR ID to changelog entry * Fix merge in Changelog * Fix table format in Changelog

navidshaikh changed the title ~~[release-0.18] Backport #1083~~ [release-0.18] Backport #1083 #1113 Nov 25, 2020

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2020

navidshaikh added the backport/pr A backport PR which is target to a release branch. label Nov 25, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020

knative-prow-robot merged commit 0a8e53b into knative:release-0.18 Nov 25, 2020

mgencur pushed a commit to openshift-knative/client that referenced this pull request Nov 21, 2022

Fix mirror script path (knative#1138)

e2ad58a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-0.18] Backport #1083 #1113 #1138

[release-0.18] Backport #1083 #1113 #1138

navidshaikh commented Nov 25, 2020 •

edited

Loading

google-cla bot commented Nov 25, 2020

navidshaikh commented Nov 25, 2020 •

edited

Loading

google-cla bot commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

navidshaikh Nov 25, 2020

rhuss Nov 25, 2020

BbolroC commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

rhuss left a comment

knative-prow-robot commented Nov 25, 2020

rhuss commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

rhuss commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

BbolroC commented Nov 25, 2020 •

edited

Loading

google-cla bot commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

navidshaikh commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

navidshaikh commented Nov 25, 2020

rhuss commented Nov 25, 2020

navidshaikh commented Nov 25, 2020 •

edited

Loading

navidshaikh commented Nov 25, 2020

BbolroC commented Nov 25, 2020 •

edited

Loading

knative-metrics-robot commented Nov 25, 2020

rhuss commented Nov 25, 2020

navidshaikh commented Nov 25, 2020

navidshaikh commented Nov 25, 2020

[release-0.18] Backport #1083 #1113 #1138

[release-0.18] Backport #1083 #1113 #1138

Conversation

navidshaikh commented Nov 25, 2020 • edited Loading

google-cla bot commented Nov 25, 2020

navidshaikh commented Nov 25, 2020 • edited Loading

google-cla bot commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

navidshaikh Nov 25, 2020

Choose a reason for hiding this comment

rhuss Nov 25, 2020

Choose a reason for hiding this comment

BbolroC commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

rhuss left a comment

Choose a reason for hiding this comment

knative-prow-robot commented Nov 25, 2020

rhuss commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

rhuss commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

BbolroC commented Nov 25, 2020 • edited Loading

google-cla bot commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

navidshaikh commented Nov 25, 2020

google-cla bot commented Nov 25, 2020

navidshaikh commented Nov 25, 2020

rhuss commented Nov 25, 2020

navidshaikh commented Nov 25, 2020 • edited Loading

navidshaikh commented Nov 25, 2020

BbolroC commented Nov 25, 2020 • edited Loading

knative-metrics-robot commented Nov 25, 2020

rhuss commented Nov 25, 2020

navidshaikh commented Nov 25, 2020

navidshaikh commented Nov 25, 2020

navidshaikh commented Nov 25, 2020 •

edited

Loading

navidshaikh commented Nov 25, 2020 •

edited

Loading

BbolroC commented Nov 25, 2020 •

edited

Loading

navidshaikh commented Nov 25, 2020 •

edited

Loading

BbolroC commented Nov 25, 2020 •

edited

Loading