Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated --async flag support #1094

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Drop deprecated --async flag support #1094

merged 1 commit into from
Nov 9, 2020

Conversation

navidshaikh
Copy link
Collaborator

Description

Drop deprecated --async flag support in the favor of --no-wait flag

Changes

  • Drop --async flag
  • Remove the respective test cases
  • Add CHANGELONG

Reference

Fixes #1089

@navidshaikh
Drop deprecated --async flag support
fe520a1 
 in the favor of --no-wait flag
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 6, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service/create.go 82.6% 84.7% 2.1
pkg/kn/commands/service/update.go 90.9% 92.5% 1.5
pkg/kn/flags/bool.go 90.0% 88.1% -1.9

rhuss
rhuss reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 45ffade into knative:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss left review comments

@cppforlife cppforlife Awaiting requested review from cppforlife

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop deprecated --async flag in favor of --no-wait
4 participants
@navidshaikh @knative-metrics-robot @knative-prow-robot @rhuss