feat: Add channel sink prefix #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
approved
There was a problem hiding this comment.
@navidshaikh: 0 warnings.
In response to this:
Description
Add channel sink prefix, so user can now specify
--sink channel:pipe0Changes
- Add channel sink prefix
- Add unit and e2e tests
- Add CHANGELOG
Reference
Fixes #1076
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
size/M
|
/retest |
rhuss
reviewed
Nov 9, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
navidshaikh
added a commit
to navidshaikh/client
that referenced
this pull request
Nov 10, 2020
* Add channel sink prefix * Add unit and e2e tests * Add CHANGELOG * Fix e2e tests
navidshaikh
added
the
backport/candidate
navidshaikh
added a commit
to navidshaikh/client
that referenced
this pull request
Nov 10, 2020
* Add channel sink prefix * Add unit and e2e tests * Add CHANGELOG * Fix e2e tests
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 10, 2020
navidshaikh
added
backported-to/0.17
and removed
backport/candidate
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 11, 2020
* feat: Add channel sink prefix (#1092) * Add channel sink prefix * Add unit and e2e tests * Add CHANGELOG * Fix e2e tests * Add CHANGELOG for v0.17.3 * Add Channel type to dynamic client for lookup Fixes unit tests by adding Channel GVK to fake dynamic client * Set KNATIVE_EVENTING_VERSION to v0.17.9 for e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add channel sink prefix, so user can now specify
--sink channel:pipe0Changes
Reference
Fixes #1076
/lint