Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tekton e2e): Fix CONTAINER_REGISTRY name generation #1074

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

navidshaikh
Copy link
Collaborator

var E2E_BASE_NAME is no longer available

@navidshaikh navidshaikh requested a review from mgencur October 26, 2020 13:51
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 26, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2020
@navidshaikh
Copy link
Collaborator Author

-------------------------------
---- Running test pipeline ----
-------------------------------
---- Mon Oct 26 07:06:56 PDT 2020
-------------------------------
Running go test with args: -race -count=1 -timeout=30m -tags=tekton ./test/e2e
=== RUN   TestTektonPipeline
--- PASS: TestTektonPipeline (152.77s)
PASS
ok  	knative.dev/client/test/e2e	152.879s
DONE 1 tests in 220.755s

tests passed ref: logs
They were failing earlier with mentioned issue https://testgrid.knative.dev/client#tekton
cc: @mgencur

reverting the debug commit

@mgencur
Copy link
Contributor

mgencur commented Oct 26, 2020

/lgtm

Thanks!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@knative-prow-robot knative-prow-robot merged commit abb75e4 into knative:master Oct 26, 2020
@navidshaikh navidshaikh deleted the pr/tekton-e2e-fix branch October 26, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants