Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range options to --scale #1070

Closed
wants to merge 39 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
3db3cdb
Add range options to --scale
Oct 22, 2020
7f91820
Updated scale flag so that the docs update with the correct information
Oct 22, 2020
2edf4c4
genereted docs instead of updating manually
Oct 22, 2020
84eb376
Update common github actions (#1072)
knative-automation Oct 26, 2020
abb75e4
fix(tekton e2e): Fix CONTAINER_REGISTRY name generation (#1074)
navidshaikh Oct 26, 2020
2b7631a
Updated --scale docs
Oct 26, 2020
33d9193
Broke up if/else into two if statements in tests
Oct 26, 2020
efa9e27
Added missing ")" in scale docs
Oct 26, 2020
537973f
Generated docs after updating configuration_edit_flags
Oct 26, 2020
ed67482
Add ResolvePodSpec to podspec.go and move the related utilities to po…
Oct 27, 2020
a75cb2c
Resolved setting either value to 0, re-ordered which gets set first f…
Oct 27, 2020
c31eac4
Fixing lint issues
Oct 28, 2020
6d00de6
Update common github actions (#1081)
knative-automation Oct 29, 2020
6ed76ae
uniform multiple writeSink into DescribeSink (#1075)
Oct 29, 2020
6fa4098
Split up helper function, updated wording in help section
Oct 29, 2020
ad4a7b1
Pin deps back to master (#1082)
navidshaikh Oct 30, 2020
d1552ee
updating to use the hack repo (#1084)
Oct 30, 2020
8ca97c7
Feature: "kn service apply" (#964)
rhuss Nov 2, 2020
c60b851
Export test refactor (#1069)
itsmurugappan Nov 2, 2020
8a0067d
upgrade to latest dependencies (#1085)
knative-automation Nov 3, 2020
3614bd6
upgrade to latest dependencies (#1088)
knative-automation Nov 3, 2020
5787e95
upgrade to latest dependencies (#1091)
knative-automation Nov 6, 2020
a0ddad9
Update common github actions (#1090)
knative-automation Nov 6, 2020
4b84de3
got rid of helper functions, cleaned up code so it is easier to read,…
Nov 6, 2020
26867f1
feat: Add channel sink prefix (#1092)
navidshaikh Nov 9, 2020
45ffade
Drop deprecated --async flag support (#1094)
navidshaikh Nov 9, 2020
b72e4be
feat: Add service import command (#1065)
dsimansk Nov 9, 2020
1f0e5f9
Add range options to --scale
Oct 22, 2020
0075a6e
Updated scale flag so that the docs update with the correct information
Oct 22, 2020
629b995
genereted docs instead of updating manually
Oct 22, 2020
a6279dc
Updated --scale docs
Oct 26, 2020
5da8f3c
Broke up if/else into two if statements in tests
Oct 26, 2020
9567f05
Added missing ")" in scale docs
Oct 26, 2020
0ede82b
Generated docs after updating configuration_edit_flags
Oct 26, 2020
b3e962a
Resolved setting either value to 0, re-ordered which gets set first f…
Oct 27, 2020
871ba72
Fixing lint issues
Oct 28, 2020
55c9980
Split up helper function, updated wording in help section
Oct 29, 2020
be8e590
got rid of helper functions, cleaned up code so it is easier to read,…
Nov 6, 2020
3a0c74e
Merge branch 'issue-822-pt3' of github.com:mpetason/client into issue…
Nov 9, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/knative-boilerplate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/mattmoor/knobots and will be overwritten.
# repo by knobots: https://github.com/knative-sandbox/knobots and will be overwritten.

name: Boilerplate

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/knative-donotsubmit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/mattmoor/knobots and will be overwritten.
# repo by knobots: https://github.com/knative-sandbox/knobots and will be overwritten.

name: Do Not Submit

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/knative-go-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/mattmoor/knobots and will be overwritten.
# repo by knobots: https://github.com/knative-sandbox/knobots and will be overwritten.

name: Build

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/knative-go-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/mattmoor/knobots and will be overwritten.
# repo by knobots: https://github.com/knative-sandbox/knobots and will be overwritten.

name: Test

Expand Down
155 changes: 155 additions & 0 deletions .github/workflows/knative-releasability.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,155 @@
# Copyright 2020 The Knative Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/mattmoor/knobots and will be overwritten.

name: 'Releasability'

on:
schedule:
- cron: '0 1 * * 1-5' # 6am Pacific, weekdays.

workflow_dispatch: # Manual trigger.
inputs:
releaseFamily:
description: 'Release? (vX.Y)'
slackChannel:
description: 'Slack Channel? (release-#)'

jobs:
releasability:
name: Releasability
runs-on: 'ubuntu-latest'

env:
#########################################
# Update this section each release. #
RELEASE: 'v0.19'
SLACK_CHANNEL: 'release-19'
#########################################

steps:
- name: Defaults
run: |
# If manual trigger sent releaseFamily and slackChannel, then override them
if [[ "${{ github.event.inputs.releaseFamily }}" != "" ]]; then
echo "RELEASE=${{ github.event.inputs.releaseFamily }}" >> $GITHUB_ENV
fi
if [[ "${{ github.event.inputs.slackChannel }}" != "" ]]; then
echo "SLACK_CHANNEL=${{ github.event.inputs.slackChannel }}" >> $GITHUB_ENV
fi

- name: Set up Go 1.15.x
uses: actions/setup-go@v2
with:
go-version: 1.15.x

- name: Install Dependencies
run: GO111MODULE=on go get knative.dev/test-infra/buoy@master

- name: Check out code
uses: actions/checkout@v2

- name: Exists
id: exists
run: |
EXISTS=0
buoy exists go.mod --release ${RELEASE} --verbose || EXISTS=$?
if [[ "$EXISTS" -eq "0" ]]; then
EXISTS=true
else
EXISTS=false
fi
echo ::set-output name=release-branch::${EXISTS}

- name: Check
if: steps.exists.outputs.release-branch == 'false'
run: |
# The following pushes the stdout of buoy into $CHECK_MESSAGE
CHECK=0
echo 'CHECK_MESSAGE<<EOF' >> $GITHUB_ENV
buoy check go.mod --release ${RELEASE} --domain knative.dev --verbose >> $GITHUB_ENV 2>&1 || CHECK=$?
echo 'EOF' >> $GITHUB_ENV

# We just captured the return code of the buoy call, test it to see
# if we should continue validating. The next steps short circuit if
# we already know we are not ready for a release.
if [[ "$CHECK" -eq "0" ]]; then
echo 'current=true' >> $GITHUB_ENV
else
echo 'current=false' >> $GITHUB_ENV
fi

- name: Upgrade
if: steps.exists.outputs.release-branch == 'false' && env.current == 'true'
run: |
# if update deps returns un-successful, then mark current to false.
if ! ./hack/update-deps.sh --release ${RELEASE} --upgrade; then
echo "VERIFY_MESSAGE=Unable to update deps for ${{ github.repository }}." >> $GITHUB_ENV
echo 'current=false' >> $GITHUB_ENV
fi

- name: Verify
if: steps.exists.outputs.release-branch == 'false' && env.current == 'true'
run: |
# If we don't run `git status` before the "git diff-index" it seems
# to list every file that's been touched by codegen.
git status
FOUND_DIFF=0
for x in $(git diff-index --name-only HEAD --); do
if [ "$(basename $x)" = "go.mod" ]; then
continue
elif [ "$(basename $x)" = "go.sum" ]; then
continue
elif [ "$(basename $x)" = "modules.txt" ]; then
continue
fi
echo "Found non-module diff: $x"
FOUND_DIFF=1
break
done

# If we see no changes after the upgrade, then we are up to date.
if [[ "$FOUND_DIFF" -eq "0" ]]; then
echo "VERIFY_MESSAGE=${{ github.repository }} up to date." >> $GITHUB_ENV
else
echo "VERIFY_MESSAGE=${{ github.repository }} is out of date." >> $GITHUB_ENV
echo 'current=false' >> $GITHUB_ENV
fi

- name: Status GO
if: steps.exists.outputs.release-branch == 'false' && env.current == 'true'
run: |
echo 'SLACK_COLOR=#098e00' >> $GITHUB_ENV
echo 'SLACK_TITLE=Releasability for ${{ github.repository }} @ ${{ env.RELEASE }} is GO!' >> $GITHUB_ENV

- name: Status NO-GO
if: steps.exists.outputs.release-branch == 'false' && env.current == 'false'
run: |
echo 'SLACK_COLOR=#8E1600' >> $GITHUB_ENV
echo 'SLACK_TITLE=Releasability for ${{ github.repository }} @ ${{ env.RELEASE }} is NO-GO!' >> $GITHUB_ENV

- name: Post status to Slack
if: steps.exists.outputs.release-branch == 'false'
uses: rtCamp/[email protected]
env:
SLACK_ICON: http://github.com/knative.png?size=48
SLACK_USERNAME: github-actions
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
MSG_MINIMAL: 'true'
SLACK_MESSAGE: |
${{ env.CHECK_MESSAGE }}
${{ env.VERIFY_MESSAGE }}
For detailed logs: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}
96 changes: 96 additions & 0 deletions .github/workflows/knative-release-notes.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
# Copyright 2020 The Knative Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/knative-sandbox/knobots and will be overwritten.

name: 'Release Notes'

on:
workflow_dispatch:
inputs:
branch:
description: 'Branch? (master)'
required: true
default: 'master'
start-sha:
description: 'Starting SHA? (last tag on branch)'
end-sha:
description: 'Ending SHA? (latest HEAD)'

jobs:
release-notes:
name: Release Notes
runs-on: 'ubuntu-latest'

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

steps:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.15.x

- name: Install Dependencies
run: GO111MODULE=on go get k8s.io/release/cmd/release-notes

- name: Check out code
uses: actions/checkout@v2
with:
# fetch-depth of 0 indicates all history for all branches and tags.
fetch-depth: 0

# Note: Defaults needs to run after we check out the repo.
- name: Defaults
run: |
echo ORG=$(echo '${{ github.repository }}' | awk -F '/' '{print $1}') >> $GITHUB_ENV
echo REPO=$(echo '${{ github.repository }}' | awk -F '/' '{print $2}') >> $GITHUB_ENV

echo "BRANCH=${{ github.event.inputs.branch }}" >> $GITHUB_ENV

if [[ "${{ github.event.inputs.start-sha }}" != "" ]]; then
echo "START_SHA=${{ github.event.inputs.start-sha }}" >> $GITHUB_ENV
else
# Default Starting SHA (thanks @dprotaso)
export semver=$(git describe --match "v[0-9]*" --abbrev=0)
echo "Using ${semver} tag for starting sha."
echo START_SHA=$(git rev-list -n 1 "${semver}") >> $GITHUB_ENV
fi

if [[ "${{ github.event.inputs.end-sha }}" != "" ]]; then
echo "END_SHA=${{ github.event.inputs.end-sha }}" >> $GITHUB_ENV
else
# Default Ending SHA (thanks @dprotaso)
echo "END_SHA=$(git rev-list -n 1 HEAD)" >> $GITHUB_ENV
fi

- name: Generate Notes
run: |
# See https://github.com/kubernetes/release/tree/master/cmd/release-notes for options.
# Note: we are setting env vars in the Defaults step.
release-notes \
--required-author "" \
--repo-path "$(pwd)" \
--output release-notes.md

- name: Display Notes
run: |
cat release-notes.md

- name: Archive Release Notes
uses: actions/upload-artifact@v2
with:
name: release-notes.md
path: release-notes.md
5 changes: 4 additions & 1 deletion .github/workflows/knative-security.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,14 @@
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/mattmoor/knobots and will be overwritten.
# repo by knobots: https://github.com/knative-sandbox/knobots and will be overwritten.

name: 'Security'

on:
push:
branches: [ 'master', 'release-*' ]

pull_request:
branches: [ 'master', 'release-*' ]

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/knative-stale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/mattmoor/knobots and will be overwritten.
# repo by knobots: https://github.com/knative-sandbox/knobots and will be overwritten.

name: 'Close stale'

Expand Down
21 changes: 15 additions & 6 deletions .github/workflows/knative-style.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/mattmoor/knobots and will be overwritten.
# repo by knobots: https://github.com/knative-sandbox/knobots and will be overwritten.

name: Code Style

Expand Down Expand Up @@ -57,8 +57,14 @@ jobs:

- name: ${{ matrix.tool }} ${{ matrix.options }}
shell: bash
run: |
${{ matrix.tool }} ${{ matrix.options }} -w $(find . -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
run: >
${{ matrix.tool }} ${{ matrix.options }} -w
$(find .
-path './vendor' -prune
-o -path './third_party' -prune
-o -name '*.pb.go' -prune
-o -name 'wire_gen.go' -prune
-o -type f -name '*.go' -print)

- name: Verify ${{ matrix.tool }}
shell: bash
Expand Down Expand Up @@ -93,6 +99,8 @@ jobs:
uses: actions/checkout@v2

- name: Install Tools
env:
WOKE_VERSION: v0.1.15
run: |
TEMP_PATH="$(mktemp -d)"
cd $TEMP_PATH
Expand All @@ -119,7 +127,7 @@ jobs:
if: steps.golangci_configuration.outputs.files_exists == 'true'
uses: golangci/golangci-lint-action@v2
with:
version: v1.30
version: v1.32

- name: misspell
shell: bash
Expand Down Expand Up @@ -237,7 +245,9 @@ jobs:
elif echo $ch | grep --quiet -E "fmt\." ; then # all other fmt. printers.
err=$(echo $ch | sed -E 's/(fmt\.)(Print|Fprint)f([^%]+) (%[^sTxq]",)([^,]+)/\1\2\3",\5/')
fi
echo "$file:$line: Please consider avoiding tail format like this:%0A$err"
# Trim spaces.
ch=$(echo $ch | xargs)
echo "$file:$line: Please consider avoiding tail format like this:%0A- $ch%0A+ $err"
done |
reviewdog -efm="%f:%l: %m" \
-name="Redundant Format" \
Expand All @@ -254,7 +264,6 @@ jobs:
shell: bash
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ github.token }}
WOKE_VERSION: v0.1.11
run: |
set -e
cd "${GITHUB_WORKSPACE}" || exit 1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/knative-verify.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# This file is automagically synced here from github.com/knative-sandbox/.github
# repo by knobots: https://github.com/mattmoor/knobots and will be overwritten.
# repo by knobots: https://github.com/knative-sandbox/knobots and will be overwritten.

name: Verify

Expand Down
Loading