Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.17] Backport #1052 and #1054 #1058

Merged
merged 3 commits into from
Oct 12, 2020
Merged

[release-0.17] Backport #1052 and #1054 #1058

merged 3 commits into from
Oct 12, 2020

Conversation

navidshaikh
Copy link
Collaborator

rhuss and others added 3 commits October 9, 2020 20:15
@rhuss @navidshaikh
Fix for test flake when sync waiting and an intermediate error occurs (…
6a7267e 
…knative#1052)

* fix: Cancel error timer on sync wait when a non-error event arrives

* chore: Added
@zroubalik @navidshaikh
Add WithLabel list filter to serving client lib (knative#1054)
fa4f4c3 
* add WithLabel list filter

Signed-off-by: Zbynek Roubalik <[email protected]>

* adding tests

Signed-off-by: Zbynek Roubalik <[email protected]>

* update changelog

Signed-off-by: Zbynek Roubalik <[email protected]>
@navidshaikh
Update CHANGELOG
29655c8
@google-cla
Copy link

google-cla bot commented Oct 12, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Indicates the PR's author has not signed the CLA. label Oct 12, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2020
@navidshaikh navidshaikh added the backport/pr A backport PR which is target to a release branch. label Oct 12, 2020
@zroubalik
Copy link
Contributor

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Oct 12, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@navidshaikh
Copy link
Collaborator Author

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Oct 12, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@rhuss
Copy link
Contributor

rhuss commented Oct 12, 2020

@googlebot I consent.

@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Oct 12, 2020
@rhuss
Copy link
Contributor

rhuss commented Oct 12, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2020
@knative-prow-robot knative-prow-robot merged commit 2d1944d into knative:release-0.17 Oct 12, 2020
dsimansk added a commit to dsimansk/client that referenced this pull request Jun 1, 2022
@dsimansk
[release-v1.2.0] Add kn-plugin-event v1.2.0 (knative#1058)
e81b838 
* [release-v1.2.0] Add kn-plugin-event v1.2.0

* Update vendor dir

* Fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport/pr A backport PR which is target to a release branch. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navidshaikh @knative-prow-robot @zroubalik @rhuss