fix(e2e): Let the subscription and related resource reconcile #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
approved
mattmoor
reviewed
Oct 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sleep for 5 seconds after subscription create and update in e2e
navidshaikh
force-pushed
the
pr/fix-sub-e2e
branch
from
986ebac to
f899e59
Compare
|
/lgtm |
navidshaikh
added a commit
to navidshaikh/client
that referenced
this pull request
Oct 7, 2020
…e#1044) sleep for 5 seconds after subscription create and update in e2e
navidshaikh
added
the
backport/candidate
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 7, 2020
* Added back functionality to deprecated max-scale/min-scale (#1010) * Added back functionality to deprecated max-scale/min-scale * Updated based on review, removed duplicate code and added an or statement, also updated deprecated message * fix(e2e): Let the subscription and related resource reconcile (#1044) sleep for 5 seconds after subscription create and update in e2e * Update CHANGELOG Co-authored-by: Mike Petersen <[email protected]>
navidshaikh
added
backported-to/0.17
and removed
backport/candidate
rhuss
pushed a commit
to rhuss/knative-client
that referenced
this pull request
Oct 12, 2020
…e#1044) sleep for 5 seconds after subscription create and update in e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sleep for 5 seconds after subscription create and update in e2e