Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update version command for release v0.18.0 #1037

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

navidshaikh
Copy link
Collaborator

Description

Mention serving/eventing vendor version v0.18.0

 Mention serving/eventing vendor version v0.18.0
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 30, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2020
@navidshaikh navidshaikh added this to the v0.18.0 milestone Sep 30, 2020
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arghya88
Copy link
Contributor

arghya88 commented Oct 1, 2020

/retest

@navidshaikh
Copy link
Collaborator Author

/retest

eventing setup flake

@navidshaikh
Copy link
Collaborator Author

/retest

1 similar comment
@rhuss
Copy link
Contributor

rhuss commented Oct 1, 2020

/retest

@maximilien
Copy link
Contributor

maximilien commented Oct 1, 2020

/test pull-knative-client-integration-tests-latest-release

@knative-prow-robot
Copy link
Contributor

@maximilien: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-knative-client-build-tests
  • /test pull-knative-client-unit-tests
  • /test pull-knative-client-integration-tests
  • /test pull-knative-client-go-coverage
  • /test pull-knative-client-integration-tests-latest-release

Use /test all to run all jobs.

In response to this:

/test pull-knative-client-integration-tests-latest-release****

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maximilien
Copy link
Contributor

/test pull-knative-client-integration-tests-latest-release

@rhuss
Copy link
Contributor

rhuss commented Oct 2, 2020

hmm, the integration test issue doesn't seems to be a flake.

@matzew has there been any change recently in eventing ? We have issues during setup that eventing doesn't starts up properly:

customresourcedefinition.apiextensions.k8s.io/inmemorychannels.messaging.knative.dev unchanged
deployment.apps/imc-controller created
deployment.apps/imc-dispatcher created
Waiting until all pods in namespace knative-eventing are up......................................................................................................................................................
ERROR: timeout waiting for pods to come up
eventing-controller-6fc9c6cfc4-8n5j5    1/1   Running   0     5m34s
eventing-webhook-667c8f6dc4-g88wx       0/1   Running   6     5m34s
imc-controller-6c4f87765c-np6mw         1/1   Running   0     5m23s
imc-dispatcher-74dcf4647f-cqjtk         1/1   Running   0     5m23s
mt-broker-controller-6d789b944d-h68dd   1/1   Running   0     5m24s
skipped 352 lines unfold_more
---- Thu Oct  1 16:04:56 PDT 2020
----------------------------------:-------------------------------
deployment.apps/sugar-controller created
Waiting until all pods in namespace knative-eventing are up......................................................................................................................................................
ERROR: timeout waiting for pods to come up
eventing-controller-6fc9c6cfc4-8n5j5    1/1   Running            0     10m
eventing-webhook-667c8f6dc4-g88wx       0/1   CrashLoopBackOff   7     10m
imc-controller-6c4f87765c-np6mw         1/1   Running            0     10m
imc-dispatcher-74dcf4647f-cqjtk         1/1   Running            0     10m
mt-broker-controller-6d789b944d-h68dd   1/1   Running            0     10m
skipped 345 lines unfold_more
2020/10/01 23:08:19 http: TLS handshake error from 10.24.0.1:59356: server key missing
2020/10/01 23:08:20 http: TLS handshake error from 10.24.0.1:59366: server key missing
2020/10/01 23:08:21 http: TLS handshake error from 10.24.0.1:59374: server key missing
2020/10/01 23:08:22 http: TLS handshake error from 10.24.0.1:59384: server key missing
2020/10/01 23:08:23 http: TLS handshake error from 10.24.0.1:59394: server key missing
ERROR: Knative setup failed

@navidshaikh
Copy link
Collaborator Author

/retest

looks like we're hitting knative/eventing#4165 which is merged yesterday in master and needs to backported to v0.18 ?

@rhuss
Copy link
Contributor

rhuss commented Oct 2, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit adb3793 into knative:master Oct 2, 2020
rhuss pushed a commit to rhuss/knative-client that referenced this pull request Oct 5, 2020
Mention serving/eventing vendor version v0.18.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants