Fix channel create example with inbuilt alias for imcv1beta1 #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `imcv1beta1` alias reference in the example
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
navidshaikh
commented
Sep 10, 2020
Comment on lines
+20
to
22
| # Create a channel 'imc1' of type InMemoryChannel using inbuilt alias 'imcv1beta1' | ||
| kn channel create imc1 --type imcv1beta1 | ||
| # same as above without using inbuilt alias but providing explicit GVK |
There was a problem hiding this comment.
in line with whats mentioned on line no 22
|
/test pull-knative-client-integration-tests |
|
Thanks! :) |
navidshaikh
added
the
backport/pr
navidshaikh
added a commit
to navidshaikh/client
that referenced
this pull request
Oct 2, 2020
…#1005) use `imcv1beta1` alias reference in the example
navidshaikh
added
backport/candidate
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 2, 2020
* Fix channel create example with inbuilt alias for imcv1beta1 (#1005) use `imcv1beta1` alias reference in the example * feat: Subscription CRUD (#1013) * feat: Add subscription CRUD - Add kn subscription command group and CRUDL sub-commands - create/update uses following flag names for better alignment: - --sink for subscriber - --sink-reply for reply - --sink-dead-letter for dead-letter-sink - Add 'subscriptions' and 'sub' aliases - Introduce shared library `knative.dev/client/lib/printing` to print Sink object in describe output * Set default channel type messaging.knative.dev/v1beta1:Channel i.e. if no prefix is given to `--channel`, consider it of `Channel` type * Update e2e tests * Update channel flag description * CHANGELOG for v0.17.1 * Conform with k8s.io/api v0.17.6
rhuss
pushed a commit
to rhuss/knative-client
that referenced
this pull request
Oct 5, 2020
…#1005) use `imcv1beta1` alias reference in the example
navidshaikh
added
backported-to/0.17
and removed
backport/candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
imcv1beta1alias reference in the example