Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[source list] Add custom type for different types of source objects #953

Closed
navidshaikh opened this issue Jul 28, 2020 · 0 comments · Fixed by #980
Closed

[source list] Add custom type for different types of source objects #953

navidshaikh opened this issue Jul 28, 2020 · 0 comments · Fixed by #980
Labels
kind/feature New feature or request
Milestone
v0.17.0

Comments

@navidshaikh
Copy link
Collaborator

Feature request

kn source list gives you objects of different types of sources. While printing the JSON/YAML format of list, we'd need
proper values for apiVersion and kind fields of the list printed, since the objects list contains are of different types.

Current behavior, sets empty string for apiVersion and List for kind.
This is to track setting these fields to for eg: apiVersion: client.knative.dev/v1alpha1
ref: #948 (comment)

There is also a discussion about what apiVersion and kind values should be if, the source list is of single type source OR --type filter is given with single type to kn source list, in this scenario, only single type of source objects are printed.
@navidshaikh navidshaikh added the kind/feature New feature or request label Jul 28, 2020
@navidshaikh navidshaikh mentioned this issue Jul 28, 2020
Merged
@navidshaikh navidshaikh added this to the v0.17.0 milestone Aug 18, 2020
navidshaikh added a commit to navidshaikh/client that referenced this issue Aug 18, 2020
@navidshaikh
Set client custom GVK for source list for machine readable output
76f0f2a 
 - Use custome GVK {Group: client.knative.dev, Version: v1alpha1, Kind: SourceList}
 - Source list may contain different source types CO and machine readable output (using -o)
   requires List object to have GVK set, since the list contains different types of source COs,
   we set a custom client GVK on it.

 Fixes knative#953
navidshaikh added a commit to navidshaikh/client that referenced this issue Aug 18, 2020
@navidshaikh
Set client custom GVK for source list for machine readable output
1a96081 
 - Use custome GVK {Group: client.knative.dev, Version: v1alpha1, Kind: SourceList}
 - Source list may contain different source types CO and machine readable output (using -o)
   requires List object to have GVK set, since the list contains different types of source COs,
   we set a custom client GVK on it.

 Fixes knative#953
@navidshaikh navidshaikh mentioned this issue Aug 18, 2020
Merged
navidshaikh added a commit to navidshaikh/client that referenced this issue Aug 18, 2020
@navidshaikh
Set client custom GVK for source list for machine readable output
cecb219 
 - Use custom GVK {Group: client.knative.dev, Version: v1alpha1, Kind: SourceList}
 - Source list may contain different source types CO and machine readable output (using -o)
   requires List object to have GVK set, since the list contains different types of source COs,
   we set a custom client GVK on it.

 Fixes knative#953
knative-prow-robot pushed a commit that referenced this issue Aug 18, 2020
@navidshaikh
Set client custom GVK for source list for machine readable output (#980)
0f95aa5 
- Use custom GVK {Group: client.knative.dev, Version: v1alpha1, Kind: SourceList}
 - Source list may contain different source types CO and machine readable output (using -o)
   requires List object to have GVK set, since the list contains different types of source COs,
   we set a custom client GVK on it.

 Fixes #953
navidshaikh added a commit to navidshaikh/client that referenced this issue Aug 18, 2020
@navidshaikh
Set client custom GVK for source list for machine readable output (kn…
b6172e1 
…ative#980)

- Use custom GVK {Group: client.knative.dev, Version: v1alpha1, Kind: SourceList}
 - Source list may contain different source types CO and machine readable output (using -o)
   requires List object to have GVK set, since the list contains different types of source COs,
   we set a custom client GVK on it.

 Fixes knative#953
knative-prow-robot pushed a commit that referenced this issue Aug 19, 2020
@navidshaikh @Kaustubh-pande
@cardil @gosoon @hemanrnjn
v0.16.1 release backports (#982)
4828914 
* fix(docs): Fix tekton task link in README (#934)

* Fix missing NAMESPACE column header (#951)

* Fix missing NAMESPACE column header

* Fix missing namespace column header for 'kn source list -A'

* List inbuilt sources if CRD access is restricted (#948)

* List inbuilt sources if CRD access is restricted

 Fixes #947
 - Identify restricted access error
 - If server returns restricted access error, fallback to listing
   only eventing inbuilt sources using their GVKs.
 - List any inbuilt source (ApiServerSource) object and read the error
   to know if eventing is installed for `kn source list-types`.

* Fix golint warnings

* Remove unused imports

* Verify each built in source before listing source types

* Improve the check if sources are not installed in the cluster

* Update finding forbidden error

* Update finding errors

* Add unit tests for IsForbiddenError util

* Add unit tests

* Add tests for dynamic pkg library

* Add unit tests for case when no sources are installed

* Update test name

* Use Tekton Catalog GA structure for tasks (#966)

* fix: `kn source list` command print spelling problems (#963)

* Fix exit code on service delete and revision delete (#971)

* Fix exit code 0 upon service delete

* Mentioned bug fix in CHANGELOG.adoc

* Add error check test for service not found

* Fix for kn revision delete failure exit code and add test cases

* Testing changes in test cases for failure in intergration tests

* Fix test case error causing integration test failure

* fix(volume): Generate volume name compliant with DNS Label names (#975)

* fix(volume): Volume names to not contain dots

 Replace non alphanumberic characters with hyphen as the
 volumen name must be a DNS_LABEL (https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names)
 ref: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#volume-v1-core

* Generate volume name compliant with DNS Label names

 Volume names to follow the DNS label standard as defined in RFC 1123. This means the name must:
 - contain at most 63 characters
 - contain only lowercase alphanumeric characters or '-'
 - start with an alphanumeric character
 - end with an alphanumeric character

* Set client custom GVK for source list for machine readable output (#980)

- Use custom GVK {Group: client.knative.dev, Version: v1alpha1, Kind: SourceList}
 - Source list may contain different source types CO and machine readable output (using -o)
   requires List object to have GVK set, since the list contains different types of source COs,
   we set a custom client GVK on it.

 Fixes #953

* Update CHANGELOG for v0.16.1

Co-authored-by: kaustubh <[email protected]>
Co-authored-by: Chris Suszynski <[email protected]>
Co-authored-by: tianfeiyu <[email protected]>
Co-authored-by: Himanshu Ranjan <[email protected]>
rhuss pushed a commit to rhuss/knative-client that referenced this issue Sep 9, 2020
@navidshaikh @rhuss
Set client custom GVK for source list for machine readable output (kn…
fc2dcd6 
…ative#980)

- Use custom GVK {Group: client.knative.dev, Version: v1alpha1, Kind: SourceList}
 - Source list may contain different source types CO and machine readable output (using -o)
   requires List object to have GVK set, since the list contains different types of source COs,
   we set a custom client GVK on it.

 Fixes knative#953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging a pull request may close this issue.

Set client custom GVK for source list for machine readable output navidshaikh/client
1 participant
@navidshaikh