Proposal: Introduce a "public" top-level package directory for sharing outside

[rhuss]

One design goal of kn was also to expose a public API to offer common client functionality to other go based applications. We already have some of those API hooks but at various places:

• The client API interfaces at
  • pkg/serving/v1
  • pkg/sources/v1alpha2
  • pkg/eventing/v1beta1
• A testing lib for E2E tests in
  • lib/test
• Utilities for parsing kn flags
  • pkg/kn/flags

This proposal suggests introducing a top-level package under which all externally shared code is collected.

This could be either the already exposed lib or maybe something more explicit like public.
Also, a CI test should check for whether any file of this directory is touched and raise some awareness (like an extra label) that a review should check for any backward compatibility issues.

Please add a 👍 for being positive for this change, 👎 if you against it.

[rhuss]

ballot is over, all positive. Thanks !

/assign rhuss

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[rhuss]

/remove-lifecycle stale

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[rhuss]

/remove-lifecycle stale

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[dsimansk]

/remove-lifecycle stale

[rhuss]

@dsimansk I think we can close this issue but use it as an input for the new shared pkg repo structure ?

[dsimansk]

@rhuss yep, works for me.

[rhuss]

Closing this and track it in #1039