Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify parameters in e2e tests #772

Closed
maximilien opened this issue Apr 1, 2020 · 1 comment · Fixed by #773
Closed

refactor: simplify parameters in e2e tests #772

maximilien opened this issue Apr 1, 2020 · 1 comment · Fixed by #773
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@maximilien
Copy link
Contributor

Refactor

From PR #765

looking at result of refactoring, every lib util now need to take 3 testing related params, before it actually takes any operation related param, e.g:

func serviceCreate(t *testing.T, it *test.KnTest, r *test.KnRunResultCollector, serviceName string) {
There is repetition,
see:

type KnRunResultCollector struct {
  results    []KnRunResult
  extraDumps []string
  t          *testing.T
}
We can access testing.T from KnRunResultCollector in every test util function, this can be fixed
separately from this PR. @rhuss: WDYT?

/kind good-first-issue
/kind refactor

@maximilien maximilien added the kind/bug Categorizes issue or PR as related to a bug. label Apr 1, 2020
@maximilien
Copy link
Contributor Author

cc @navidshaikh @rhuss

@maximilien maximilien changed the title refactor: simplify parameters in refactor: simplify parameters in e2e tests Apr 2, 2020
knative-prow-robot pushed a commit that referenced this issue Apr 8, 2020
* fix(#772) refactored / simplified parameters to KnResultCollector

* added Teardown() call in VersionTest
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
dsimansk added a commit to dsimansk/client that referenced this issue Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant