You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
looking at result of refactoring, every lib util now need to take 3 testing related params, before it actually takes any operation related param, e.g:
func serviceCreate(t *testing.T, it *test.KnTest, r *test.KnRunResultCollector, serviceName string) {
There is repetition,
see:
type KnRunResultCollector struct {
results []KnRunResult
extraDumps []string
t *testing.T
}
We can access testing.T from KnRunResultCollector in every test util function, this can be fixed
separately from this PR. @rhuss: WDYT?
/kind good-first-issue
/kind refactor
The text was updated successfully, but these errors were encountered:
Refactor
From PR #765
The text was updated successfully, but these errors were encountered: