Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to run e2e tests on different platforms, e.g., Windows, Mac OS X, and Linux #741

Closed
maximilien opened this issue Mar 17, 2020 · 5 comments
Labels
kind/feature New feature or request

Comments

@maximilien
Copy link
Contributor

Feature request

Currently the e2e tests are automated in CI and run only on Linux containers. This is great but does not reflect the different platforms we intend kn users to utilize. As a user client tool, we should expect more users to actually use Windows and Mac OS X as their execution platform.

In addition, some issues have already surfaced that are specific to the user’s platform. In particular when it comes to kn plugins. See issues #738 #733 and #417.

Use case

  • running plugins on the Windows platform
  • running kn from the downloaded binary

In all of these cases, and solutions to issues above, we ideally would need to have e2e tests specific to the platform and running these tests in CI.

/kind bug

@maximilien maximilien added the kind/feature New feature or request label Mar 17, 2020
@rhuss
Copy link
Contributor

rhuss commented Mar 20, 2020

@chaodaiG @chizhg Does our Prow CI infrastructure support running on other platforms than Unix ?

coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@coryrc
Copy link
Contributor

coryrc commented May 19, 2020

@chaodaiG @chizhg Does our Prow CI infrastructure support running on other platforms than Unix ?

Well, it doesn't even support Unix! It only supports Kubernetes.

But if someone was able to provide a kubernetes cluster running Windows and created the image performing desired e2e test (along with downloading repository and uploading files to GCS) I think we actually could do this.

@coryrc
Copy link
Contributor

coryrc commented May 19, 2020

There might also be a non-Prow way of doing things that interacts with Github and could be a blocking presubmit, though there wouldn't be any periodic job.

@navidshaikh
Copy link
Collaborator

/close

feel free to re-open if you've further comments.

@knative-prow-robot
Copy link
Contributor

@navidshaikh: Closing this issue.

In response to this:

/close

feel free to re-open if you've further comments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants