Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative docs for kn CLI? #623

Closed
maximilien opened this issue Jan 23, 2020 · 5 comments
Closed

Knative docs for kn CLI? #623

maximilien opened this issue Jan 23, 2020 · 5 comments
Labels
kind/question Issue type question

Comments

@maximilien
Copy link
Contributor

maximilien commented Jan 23, 2020

In what area(s)?

Docs

/kind doc

Ask your question here:

Based on TOC discussion today (01/23) I am wondering how much docs from this repo we can submit to the official Knative docs repo? Perhaps the better approach is to submit use cases on how to use the kn client? For instance, I could submit my knfun workflow? Or should we submit simpler examples or both?

NOTE: I could open this issue on the docs side, however, I think the message today was that the docs team needs help and the agreement after today’s TOC call is to summon each sub-team to help out the docs team. So essentially this issue is to discuss what is needed and we can agree on what to submit and do it and help.

Thoughts?

CC: @mattmoor @samodell

@maximilien maximilien added the kind/question Issue type question label Jan 23, 2020
@samodell
Copy link
Contributor

Hey @maximilien ! The goal is to have the main documentation for kn to live in the Docs repo eventually. Some work is in progress to make that a reality -- we're tracking that in this project here:
https://github.com/knative/docs/projects/23

@abrennan89 and @rhuss have been collaborating on that; if you're interested, I'm sure they'd be happy to have additional hands working on those docs.

For the knfun docs you linked, I'd love to see us link out to that repo from our community samples page: https://knative.dev/community/samples/index.html

There isn't a section there yet for kn-related things yet, but we can add one! And since those aren't quite code samples in the traditional sense, maybe we should add a section for demos and consider renaming that page.

@samodell
Copy link
Contributor

And thanks for kicking off this discussion; I appreciate your interest in helping out!

@maximilien
Copy link
Contributor Author

Cool @samodell. Happy to help. You can assign me anything related to kn plugins and creation parameters to start. I'll poke around the backlog today and next week and self-assign what I think I can help with.

@maximilien
Copy link
Contributor Author

maximilien commented Jan 24, 2020

OK just sent a knative/docs PR #2132 to add knfun to a new client samples section.

@maximilien
Copy link
Contributor Author

Closing here since we have other issues being tracked for this. See @samodell comment ^^^

coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
* Use atleast 16 nodes for perf test cluster

* Add quotes to numbers when adding as env var

* Remove unnecessary if condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Issue type question
Projects
None yet
Development

No branches or pull requests

2 participants