Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support image pull secrets #616

Closed
navidshaikh opened this issue Jan 21, 2020 · 0 comments · Fixed by #617
Closed

Support image pull secrets #616

navidshaikh opened this issue Jan 21, 2020 · 0 comments · Fixed by #617
Labels
kind/feature New feature or request

Comments

@navidshaikh
Copy link
Collaborator

Classifications:

/kind feature

Describe the feature:

Support ImagePullSecrets field as enabled in Serving v0.11.1 release.
Support setting and clearing image pull secrets for service to pull images behind registry auth.
@navidshaikh navidshaikh added the kind/feature New feature or request label Jan 21, 2020
navidshaikh added a commit to navidshaikh/client that referenced this issue Jan 21, 2020
@navidshaikh
Add --pull-secret flag
9af3737 
 Fixes knative#616

 - Add --pull-secret flag for service create/update operations
 - Setting empty string to flag clears the pull secrets
 - List ImagePullSecrets for service in `service describe` default output
 - Run e2e tests against serving v0.11.1 (ImagePullSecrets introduced in this release)
navidshaikh added a commit to navidshaikh/client that referenced this issue Jan 21, 2020
@navidshaikh
Add --pull-secret flag
e4270fd 
 Fixes knative#616

 - Add --pull-secret flag for service create/update operations
 - Setting empty string to flag clears the pull secrets
 - List ImagePullSecrets for service in `service describe` default output
 - Run e2e tests against serving v0.11.1 (ImagePullSecrets introduced in this release)
@navidshaikh navidshaikh mentioned this issue Jan 21, 2020
Merged
navidshaikh added a commit to navidshaikh/client that referenced this issue Jan 21, 2020
@navidshaikh
Add --pull-secrets flag
67f0728 
 Fixes knative#616

 - Add --pull-secrets flag for service create/update operations
 - Setting empty string to flag clears the pull secrets
 - List ImagePullSecrets for service in `service describe` default output
 - Run e2e tests against serving v0.11.1 (ImagePullSecrets introduced in this release)
navidshaikh added a commit to navidshaikh/client that referenced this issue Jan 21, 2020
@navidshaikh
Add --pull-secrets flag
cbe685a 
 Fixes knative#616

 - Add --pull-secrets flag for service create/update operations
 - Setting empty string to flag clears the pull secrets
 - List ImagePullSecrets for service in `service describe` default output
 - Run e2e tests against latets serving v0.12.0 (ImagePullSecrets introduced in v0.11.1 release)
navidshaikh added a commit to navidshaikh/client that referenced this issue Jan 22, 2020
@navidshaikh
Add --pull-secrets flag
7e1591d 
 Fixes knative#616

 - Add --pull-secrets flag for service create/update operations
 - Setting empty string to flag clears the pull secrets
 - List ImagePullSecrets for service in `service describe` default output
 - Run e2e tests against latets serving v0.12.0 (ImagePullSecrets introduced in v0.11.1 release)
knative-prow-robot pushed a commit that referenced this issue Jan 22, 2020
@navidshaikh @knative-prow-robot
Add --pull-secret flag (#617)
ff7dffc 
* Add --pull-secrets flag

 Fixes #616

 - Add --pull-secrets flag for service create/update operations
 - Setting empty string to flag clears the pull secrets
 - List ImagePullSecrets for service in `service describe` default output
 - Run e2e tests against latets serving v0.12.0 (ImagePullSecrets introduced in v0.11.1 release)

* Space separated field name for describe and update flag help msg

 - Update the key name in service describe:
  - ImagePullSecrets --> Image Pull Secrets
  - ServiceAccount --> Service Account
 - Update the help message for --service-account and --pull-secrets
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Add correct alert settings for Testgrid (knative#616)
42a0171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --pull-secret flag navidshaikh/client
1 participant
@navidshaikh