Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for private KnServices #606

Closed
duglin opened this issue Jan 13, 2020 · 6 comments · Fixed by #629
Closed

Add support for private KnServices #606

duglin opened this issue Jan 13, 2020 · 6 comments · Fixed by #629
Assignees
@maximilien
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request kind/proposal Issues or PRs related to proposals.

Comments

@duglin
Copy link
Contributor

duglin commented Jan 13, 2020

In what area(s)?

/kind good-first-issue
/kind feature
/kind proposal

Describe the feature:

It would be nice if there was a way to specify that a knService should not have an external endpoint. This means setting the label serving.knative.dev/visibility: cluster-local.
@duglin duglin added the kind/feature New feature or request label Jan 13, 2020
@knative-prow-robot knative-prow-robot added good first issue Denotes an issue ready for a new contributor. kind/proposal Issues or PRs related to proposals. labels Jan 13, 2020
@rhuss
Copy link
Contributor

rhuss commented Jan 30, 2020

Good point. I suggest introducing an option --cluster-local and --no-cluster-local.

@rhuss
Copy link
Contributor

rhuss commented Jan 30, 2020

The handling could be similar like for --concurrency-target

@maximilien
Copy link
Contributor

/assign @maximilien

@maximilien
Copy link
Contributor

@duglin you OK with @rhuss suggested flags? Seems reasonable to me.

@maximilien
Copy link
Contributor

maximilien commented Jan 31, 2020 •
edited
Loading

Also, I am assuming this is both at create and update of a service.

@duglin
Copy link
Contributor Author

duglin commented Jan 31, 2020

yep sounds good on both questions

maximilien added a commit to maximilien/client that referenced this issue Feb 1, 2020
@maximilien
fixes(knative#606): adds --cluster-local / --no-cluster-local flags
64988b2 
When specified on 'service create' the '--cluster-local' flag will
make the created service 'private' by setting its config visibility
to 'cluster-local'. This is done with label:

serving.knative.dev/visibility: cluster-local

The --no-cluster-local will remove the label.
@maximilien maximilien mentioned this issue Feb 1, 2020
Merged
maximilien added a commit to maximilien/client that referenced this issue Feb 1, 2020
@maximilien
fixes(knative#606): adds --cluster-local / --no-cluster-local flags
e5e4bfc 
When specified on 'service create' the '--cluster-local' flag will
make the created service 'private' by setting its config visibility
to 'cluster-local'. This is done with label:

serving.knative.dev/visibility: cluster-local

The --no-cluster-local will remove the label.
@maximilien maximilien mentioned this issue Feb 6, 2020
Closed
knative-prow-robot pushed a commit that referenced this issue Mar 10, 2020
@maximilien
fixes(#606): adds --cluster-local / --no-cluster-local flags (#629)
2b9377d 
When specified on 'service create' the '--cluster-local' flag will
make the created service 'private' by setting its config visibility
to 'cluster-local'. This is done with label:

serving.knative.dev/visibility: cluster-local

The --no-cluster-local will remove the label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximilien maximilien

Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request kind/proposal Issues or PRs related to proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes(#606): adds --cluster-local / --no-cluster-local flags maximilien/client
4 participants
@maximilien @rhuss @duglin @knative-prow-robot