Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests for trigger #568

Closed
rhuss opened this issue Dec 17, 2019 · 2 comments · Fixed by #645
Closed

Add E2E tests for trigger #568

rhuss opened this issue Dec 17, 2019 · 2 comments · Fixed by #645
Assignees
@daisy-ycguo
Labels
area/e2e kind/feature New feature or request

Comments

@rhuss
Copy link
Contributor

rhuss commented Dec 17, 2019

This should involve the usage of a broker and a source (ideally a cronjob source) and should check if the filtering works.
@rhuss rhuss added kind/feature New feature or request topic/eventing-mvp labels Dec 17, 2019
@daisy-ycguo
Copy link
Member

Needs to enable broker as sink first. Have dependencies on issue 570 and 563

@daisy-ycguo
Copy link
Member

/assign

@rhuss rhuss added the area/e2e label Feb 5, 2020
@daisy-ycguo daisy-ycguo mentioned this issue Feb 10, 2020
Merged
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@chaodaiG @knative-prow-robot
Flaky test reporter: add unit test for github operations (knative#568)
6b8d478 
* add unit test for github opertions in flaky test reporter

* updates based on PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daisy-ycguo daisy-ycguo

Labels
area/e2e kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add E2E tests for trigger daisy-ycguo/client
2 participants
@rhuss @daisy-ycguo