Add E2E tests for CronJob source

[rhuss]

similar to for E2E tests for ApiServer source. Ideally this should involve also a service to connect to and checking whether cronjob events have been delivered.

• Add CronJob create/update/delete tests
• Verify the events at configured sink

[MIBc]

I'd like to try.

[navidshaikh]

/reopen

(for verifying the events at the sink)

[knative-prow-robot]

@navidshaikh: Reopened this issue.

In response to this:

/reopen

(for verifying the events at the sink)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[daisy-ycguo]

/reopen

(for verifying the events at the sink)

@navidshaikh will you provide more details for "verifying the events at the sink" ?

[navidshaikh]

@daisy-ycguo : We can use gcr.io/knative-releases/github.com/knative/eventing-contrib/cmd/event_display to receive events and verify events from logs.

[daisy-ycguo]

I will take care of the item: Verify the events at configured sink.

[daisy-ycguo]

/assign daisy-ycguo

[daisy-ycguo]

@rhuss @navidshaikh
I don't think we should work on this test case Verify the events at configured sink. It should be a part of e2e test of eventing. We could verify that pingsource could be described correctly. Because if pingsource could be described correctly, and eventing functions work well, it's definitely true that event message could be sent to sink.

The reason that I question this requirement is that I'm not able to implement this test case based on the GKE with Istio add-on testing environment. Eventing has the pingsource e2e test case working well with --skip-istio-addon enabled in their test environment. While if we disable istio add-on, some serving test cases might be failed according to @chizhg 's comment.

So I recommend to change the test case to verify pingsource description.

[rhuss]

Sounds reasonable, but I really wonder how eventing the e2e tests pingsource if it doesn't work with the setup given ?