Wait for the service to be Ready by default #54
Milestone
Comments
|
/assign rhuss |
|
@rhuss: GitHub didn't allow me to assign the following users: rhuss. Note that only knative members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 2, 2019
* By default wait for a service to be in condition "Ready" * Use "--async" for returning immediately (which is the current behaviour) * --wait-timeout to specify how long to wait for Ready condition (in seconds, default: 60s) * In sync mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. * Refactored service create code to use smaller methods which are easier to understand Current tests has been adapted to work with async behaviour but no new tests has been added for the new sync mode. This is coming in a second commit (and put into an extra test file). Fixes knative#54
This was referenced Jun 2, 2019
Closed
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 3, 2019
* By default wait for a service to be in condition "Ready" * Use "--async" for returning immediately (which is the current behaviour) * --wait-timeout to specify how long to wait for Ready condition (in seconds, default: 60s) * In sync mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. * Refactored service create code to use smaller methods which are easier to understand Current tests has been adapted to work with async behaviour but no new tests has been added for the new sync mode. This is coming in a second commit (and put into an extra test file). Fixes knative#54
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 3, 2019
* By default wait for a service to be in condition "Ready" * Use "--async" for returning immediately (which is the current behaviour) * --wait-timeout to specify how long to wait for Ready condition (in seconds, default: 60s) * In sync mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. * Refactored service create code to use smaller methods which are easier to understand Current tests has been adapted to work with async behaviour but no new tests has been added for the new sync mode. This is coming in a second commit (and put into an extra test file). Fixes knative#54
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 6, 2019
* By default wait for a service to be in condition "Ready" * Use "--async" for returning immediately (which is the current behaviour) * --wait-timeout to specify how long to wait for Ready condition (in seconds, default: 60s) * In sync mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. * Refactored service create code to use smaller methods which are easier to understand Current tests has been adapted to work with async behaviour but no new tests has been added for the new sync mode. This is coming in a second commit (and put into an extra test file). Fixes knative#54
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 6, 2019
* By default wait for a service to be in condition "Ready" * Use "--async" for returning immediately (which is the current behaviour) * --wait-timeout to specify how long to wait for Ready condition (in seconds, default: 60s) * In sync mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. * Refactored service create code to use smaller methods which are easier to understand Current tests has been adapted to work with async behaviour but no new tests has been added for the new sync mode. This is coming in a second commit (and put into an extra test file). Fixes knative#54
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 7, 2019
* By default wait for a service to be in condition "Ready" * Use "--async" for returning immediately (which is the current behaviour) * --wait-timeout to specify how long to wait for Ready condition (in seconds, default: 60s) * In sync mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. * Refactored service create code to use smaller methods which are easier to understand Current tests has been adapted to work with async behaviour but no new tests has been added for the new sync mode. This is coming in a second commit (and put into an extra test file). Fixes knative#54
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 9, 2019
* By default wait for a service to be in condition "Ready" * Use "--async" for returning immediately (which is the current behaviour) * --wait-timeout to specify how long to wait for Ready condition (in seconds, default: 60s) * In sync mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. * Refactored service create code to use smaller methods which are easier to understand Current tests has been adapted to work with async behaviour but no new tests has been added for the new sync mode. This is coming in a second commit (and put into an extra test file). Fixes knative#54
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 9, 2019
By default, `kn service create` blocks until the service is either created or an error occured during service creation. With the option --no-wait the behaviour can be switched to an async mode so that that kn returns immediately after the service is created without waiting for a successful Ready status condition. The timeout for how long to wait can be configured with --wait-timeout If a timeout occur, that doesn't mean that the service is not created, but the wait just returns. The default value is 60 seconds. In wait mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. Fixes knative#54
rhuss
added a commit
to rhuss/knative-client
that referenced
this issue
Jun 28, 2019
By default, `kn service create` blocks until the service is either created or an error occured during service creation. With the option --no-wait the behaviour can be switched to an async mode so that that kn returns immediately after the service is created without waiting for a successful Ready status condition. The timeout for how long to wait can be configured with --wait-timeout If a timeout occur, that doesn't mean that the service is not created, but the wait just returns. The default value is 60 seconds. In wait mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. Fixes knative#54
knative-prow-robot
pushed a commit
that referenced
this issue
Jun 28, 2019
…#156) * feat(service create): Added --no-wait and --wait-timeout By default, `kn service create` blocks until the service is either created or an error occured during service creation. With the option --no-wait the behaviour can be switched to an async mode so that that kn returns immediately after the service is created without waiting for a successful Ready status condition. The timeout for how long to wait can be configured with --wait-timeout If a timeout occur, that doesn't mean that the service is not created, but the wait just returns. The default value is 60 seconds. In wait mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. Fixes #54 * chore(service create): Tolerate if obeservedGeneration has not been set yet during startup * chore(service create): Refactored based on review comments * Introduced an --async flag (replacing --wait and --no-wait) * Added proper retry handling on the list watch * Updated help message * chore(service wait): Added a new test for sync behaviour
maximilien
pushed a commit
to maximilien/client
that referenced
this issue
Jul 1, 2019
…knative#156) * feat(service create): Added --no-wait and --wait-timeout By default, `kn service create` blocks until the service is either created or an error occured during service creation. With the option --no-wait the behaviour can be switched to an async mode so that that kn returns immediately after the service is created without waiting for a successful Ready status condition. The timeout for how long to wait can be configured with --wait-timeout If a timeout occur, that doesn't mean that the service is not created, but the wait just returns. The default value is 60 seconds. In wait mode, print out the service URL as a last line (so that it can be used together with `tail -1`) to extract the service URL after the service is created. Fixes knative#54 * chore(service create): Tolerate if obeservedGeneration has not been set yet during startup * chore(service create): Refactored based on review comments * Introduced an --async flag (replacing --wait and --no-wait) * Added proper retry handling on the list watch * Updated help message * chore(service wait): Added a new test for sync behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Use
--asyncto not wait.The text was updated successfully, but these errors were encountered: