Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorten the --log-http Authorization mask value #391

Closed
duglin opened this issue Aug 25, 2019 · 2 comments · Fixed by #484
Closed

shorten the --log-http Authorization mask value #391

duglin opened this issue Aug 25, 2019 · 2 comments · Fixed by #484
Labels
kind/feature New feature or request

Comments

@duglin
Copy link
Contributor

duglin commented Aug 25, 2019

Authorization: *************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************

Seems but excessive when something like:

Authorization: ****

will do - plus it's kind of ugly to see it in the logs. Minor thing but it's the first thing I noticed and laughed at when I saw the logs

@duglin duglin added the kind/feature New feature or request label Aug 25, 2019
@cppforlife
Copy link

(redacted) would be better imho

@sixolet
Copy link
Contributor

sixolet commented Oct 29, 2019 via email

coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
…ve#391)

* Allow disabling markdown check steps in the default build test

* Update comment in script

* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants