Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for zsh autocompletion #130

Closed
surajnarwade opened this issue May 20, 2019 · 9 comments
Closed

Add support for zsh autocompletion #130

surajnarwade opened this issue May 20, 2019 · 9 comments

Comments

@surajnarwade
Copy link
Contributor

surajnarwade commented May 20, 2019

Since cobra also supports zsh autocomplation hence $SUBJECT

(I would like to work on this 🙈 )

maximilien added a commit to maximilien/client that referenced this issue May 20, 2019
@maximilien
Copy link
Contributor

PR #132

@surajnarwade
Copy link
Contributor Author

I wanted to work but anyway thanks :)

@maximilien
Copy link
Contributor

Was not clear @surajnarwade if you were just requesting ... and I too am a zsh user and that annoyed me too but never looked to see if Cobra supported zsh until you opened this issue. Best.

@surajnarwade
Copy link
Contributor Author

@maximilien No worries 😄

@maximilien
Copy link
Contributor

@surajnarwade I think this is merged now so please verify that close if OK. Thx

@moficodes
Copy link

moficodes commented May 24, 2019

i added source < (kn completion --zsh) in my .zshrc but getting

_arguments:comparguments:319: can only be called from completion function
_arguments:comparguments:319: can only be called from completion function

Am i doing something wrong?

@maximilien

rhuss pushed a commit to rhuss/knative-client that referenced this issue May 27, 2019
maximilien added a commit to maximilien/client that referenced this issue May 28, 2019
@maximilien
Copy link
Contributor

Nope @moficodes. The generated code comes from the Cobra project. Can you provide what version of Zsh you are using and I'll try to find what is supported from the Cobra code.

@rhuss
Copy link
Contributor

rhuss commented Jul 8, 2019

Can this issue be closed as it has been implemented with #132 ?

@maximilien
Copy link
Contributor

IMO yup

@rhuss rhuss closed this as completed Jul 9, 2019
navidshaikh pushed a commit to navidshaikh/client that referenced this issue Oct 18, 2019
🤖 Triggering CI on branch 'release-next' after synching to upstream/master
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
1. For convenience.
2. To avoid this pattern being replicatd unnecessarily across all repos and scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants