chore(service update): Add "unchanged" to revision if not changed

knative · Oct 10, 2019 · d650365 · d650365
1 parent a0cb9d8
commit d650365
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/pkg/kn/commands/service/create.go b/pkg/kn/commands/service/create.go
@@ -192,7 +192,7 @@ func waitForServiceToGetReady(client serving_kn_v1alpha1.KnServingClient, name s
 	if err != nil {
 		return err
 	}
-	return showUrl(client, name, verbDone, out)
+	return showUrl(client, name, "", verbDone, out)
 }
 
 // Duck type for writers having a flush

diff --git a/pkg/kn/commands/service/service.go b/pkg/kn/commands/service/service.go
@@ -55,7 +55,7 @@ func waitForService(client serving_kn_v1alpha1.KnServingClient, serviceName stri
 	return nil
 }
 
-func showUrl(client serving_kn_v1alpha1.KnServingClient, serviceName string, what string, out io.Writer) error {
+func showUrl(client serving_kn_v1alpha1.KnServingClient, serviceName string, originalRevision string, what string, out io.Writer) error {
 	service, err := client.GetService(serviceName)
 	if err != nil {
 		return fmt.Errorf("cannot fetch service '%s' in namespace '%s' for extracting the URL: %v", serviceName, client.Namespace(), err)
@@ -64,6 +64,11 @@ func showUrl(client serving_kn_v1alpha1.KnServingClient, serviceName string, wha
 	if url == "" {
 		url = service.Status.DeprecatedDomain
 	}
-	fmt.Fprintf(out, "\nService '%s' %s with latest revision '%s' and URL:\n%s\n", serviceName, what, service.Status.LatestReadyRevisionName, url)
+	revisionUpdateStatus := ""
+	newRevision := service.Status.LatestReadyRevisionName
+	if originalRevision != "" && originalRevision == newRevision {
+		revisionUpdateStatus = " (unchanged)"
+	}
+	fmt.Fprintf(out, "\nService '%s' %s with latest revision '%s'%s and URL:\n%s\n", serviceName, what, newRevision, revisionUpdateStatus, url)
 	return nil
 }
diff --git a/pkg/kn/commands/service/update.go b/pkg/kn/commands/service/update.go
@@ -80,7 +80,7 @@ func NewServiceUpdateCommand(p *commands.KnParams) *cobra.Command {
 					return err
 				}
 				service = service.DeepCopy()
-
+				latestRevisionBeforeUpdate := service.Status.LatestReadyRevisionName
 				var baseRevision *v1alpha1.Revision
 				if !cmd.Flags().Changed("image") && editFlags.LockToDigest {
 					baseRevision, err = client.GetBaseRevision(service)
@@ -119,7 +119,7 @@ func NewServiceUpdateCommand(p *commands.KnParams) *cobra.Command {
 					if err != nil {
 						return err
 					}
-					return showUrl(client, name, "updated", out)
+					return showUrl(client, name, latestRevisionBeforeUpdate, "updated", out)
 				} else {
 					fmt.Fprintf(out, "Service '%s' updated in namespace '%s'.\n", args[0], namespace)